Repository navigation
Conversation
MbappeWU
marked this pull request as ready for review
October 5, 2026 13:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI currently adds a fallback link title when
--default-titleis absent, then disables that behavior when the flag is supplied. Its argparse action isstore_false, which reverses the option's documented opt-in meaning.Use
store_trueso the default is false and the flag enables href-based titles. Preserve explicit titles, stdin and named-file conversion, and the existing autolinks behavior. Add tests against the public CLI entry function rather than argparse internals. No converter/API, dependency, version, config or source workflow changes.Validation:
mypy .passes for 14 source files;mypy --strict tests/types.pypasses.py.typed, matching final Git. Archive integrity and Twine checks pass. Independent replay of the retained helper plus a semantic checker verifies actual installed console/module stdout, stderr and exit for 7 cases: default/flag, stdin/file, explicit title, autolinks alone and autolinks with fallback titles. The installed environment uses Python 3.8.20 and the declared dependencies.