openkal measurement: the pinned graph declares [c-abi], and a refused build is not a failed one - #444
Merged
Merged
Conversation
…time tests/openkal/pins.toml moved `runtime` from 0.10.0 to 0.12.0. Below that version no package the pin resolves declares a `[c-abi]` block, so mcpp realises nothing for the target side and the Windows leg compiles as x86_64-w64-windows-gnu with `_WIN32` defined --- the condition every `#ifdef _WIN32` branch in the measured members selects on. Every Windows result recorded under 0.10.0 therefore measures the behaviour the declaration exists to replace rather than the declaration. The descriptors for both packages were already registered (#441, #442) and their two mirrors compared byte for byte before this move: openkal-musl 0.16.0 and openkal-llvm-runtime 0.12.0 each answer the same sha256 from the GitHub archive and the GitCode asset. Co-authored-by: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 做两件事
1. 抬
tests/openkal/pins.toml的runtime：0.10.0 → 0.12.0在 0.10.0 之下，这个 pin 解析出的图里没有任何包声明
[c-abi]，因此 mcpp 对目标侧不做任何实现，Windows 腿按x86_64-w64-windows-gnu编译、_WIN32定义着——而那正是被测成员里每一个#ifdef _WIN32分支选中的条件。所以 0.10.0 下记录的每一条 Windows 结果，量的是这个声明存在的理由，而不是这个声明。
mcpp-community/mcpp#674正是针对这种形状的结果提出的。两个包的描述符早已登记（#441、#442），本次移动前逐字节比对过两侧镜像：
openkal-musl 0.16.0与openkal-llvm-runtime 0.12.0的 GitHub archive 与 GitCode 资产 sha256 相同。2.
refused：一次拒绝不是一次失败（随后推送）
判据
重测后 Windows 腿：按
_WIN32/__MINGW32__选分支的成员应当自愈；未自愈的逐条记录原因。