Repository navigation
Correction: Safari activeTab grants match patterns - #46312
Merged
Merged
Conversation
Contributor
|
Preview URLs (1 page) |
Member
Author
|
I am unable to select @kiaraarose as reviewer in the review list, but verbally spoke to her and she confirmed the expectations. Dave, FYI: you were automatically/randomly chosen as reviewer because you are now a member of the team in MDN. This change looks like something you can verify/review, so I'll keep you as reviewer. |
rebloor
approved these changes
Oct 27, 2026
kzar
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current documentation claims that Safari grants activeTab like Firefox, tied to the tab only. That is inaccurate; match patterns based on the tab's URL are granted instead.
Motivation
@kiaraarose (Apple) noted this inaccuracy when she looked at this article while working on the activeTab spec (w3c/webextensions#1152).
Additional details
In this comment on the original PR that added the docs (#45263 (comment) ) I linked to https://searchfox.org/wubkat/rev/c01e8de3c16c6d8b3c00ab2dbf958f2e8a4475b7/Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm#2384-2386 which clearly shows what is granted.
Related issues and pull requests
Fixup to #45263.