Skip to content

Move subtitles_en.vtt to shared-assets and update audio-video reference - #46451

Merged
Josh-Cena merged 2 commits into
mdn:mainfrom
abdul-karim-mia:fix/filecheck-vtt-plain-text
Nov 10, 2026
Merged

Josh-Cena merged 2 commits into
mdn:mainfrom
abdul-karim-mia:fix/filecheck-vtt-plain-text

Conversation

@abdul-karim-mia

@abdul-karim-mia abdul-karim-mia commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removes \subtitles_en.vtt\ from \mdn/content\ and points the \ est_your_skills/audio_and_video\ live sample track to /shared-assets/misc/subtitles_en.vtt.

Motivation

As requested by @Josh-Cena in review, \subtitles_en.vtt\ is moved to \mdn/shared-assets\ (PR mdn/shared-assets#106) so that it can be served via the same-origin /shared-assets/\ reverse proxy rather than living in the content repository.

Additional details

  • Removed \ iles/en-us/learn_web_development/core/structuring_content/test_your_skills/audio_and_video/subtitles_en.vtt.
  • Updated live sample track source in \ iles/en-us/learn_web_development/core/structuring_content/test_your_skills/audio_and_video/index.md\ to /shared-assets/misc/subtitles_en.vtt.
  • Restored \scripts/filecheck/\ to upstream main so no system files are touched.
  • All pre-commit checks and unit tests passed.

Related issues and pull requests

@abdul-karim-mia
abdul-karim-mia requested a review from a team as a code owner November 10, 2026 04:51
@abdul-karim-mia
abdul-karim-mia requested review from caugner and removed request for a team November 10, 2026 04:51
@github-actions github-actions Bot added system [PR only] Infrastructure and configuration for the project size/s [PR only] 6-50 LoC changed labels Nov 10, 2026

@Josh-Cena Josh-Cena left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing this, could you please remove the VTT file from content and add it to shared-assets? We added it here because tracks cannot be cross-origin. But I later realized that live samples support the /shared-assets/ reverse proxy which means this file can become same-origin.

Signed-off-by: Abdul karim mia <97598943+abdul-karim-mia@users.noreply.github.com>
@abdul-karim-mia
abdul-karim-mia force-pushed the fix/filecheck-vtt-plain-text branch from a1c1d19 to b3f642d Compare November 10, 2026 05:48
@abdul-karim-mia
abdul-karim-mia requested a review from a team as a code owner November 10, 2026 05:48
@abdul-karim-mia
abdul-karim-mia requested review from chrisdavidmills and removed request for a team November 10, 2026 05:48
@abdul-karim-mia abdul-karim-mia changed the title filecheck: ignore vtt files as plain-text files Move subtitles_en.vtt to shared-assets and update audio-video reference Nov 10, 2026
@github-actions github-actions Bot added Content:Learn Learning area docs (outside of one of the Learn:* subtags) and removed system [PR only] Infrastructure and configuration for the project labels Nov 10, 2026
@abdul-karim-mia

Copy link
Copy Markdown
Contributor Author

Updated! I opened mdn/shared-assets#106 to add \misc/subtitles_en.vtt, removed the VTT file from \mdn/content, reverted the \scripts/filecheck\ changes, and updated the live sample <track>\ reference to /shared-assets/misc/subtitles_en.vtt. Thank you!

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Preview URLs (1 page)

(comment last updated: 2026-11-10 10:09:53)

@chrisdavidmills chrisdavidmills left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdul-karim-mia, a couple of comments for you; thanks for working on this.

Of course, we need to wait for the shared-assets update to be live before merging this.

Signed-off-by: Abdul karim mia <97598943+abdul-karim-mia@users.noreply.github.com>
@abdul-karim-mia

Copy link
Copy Markdown
Contributor Author

mdn/shared-assets#106 has just been merged upstream. Ready for review whenever you have a moment! Thank you.

@chrisdavidmills chrisdavidmills left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM. Thanks again, @abdul-karim-mia.

@Josh-Cena Josh-Cena left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you

@Josh-Cena
Josh-Cena merged commit 22768e8 into mdn:main Nov 10, 2026
13 checks passed
@abdul-karim-mia
abdul-karim-mia deleted the fix/filecheck-vtt-plain-text branch November 10, 2026 14:21
pepelsbey added a commit to pepelsbey/mdn-content that referenced this pull request Nov 12, 2026
* upstream/main: (204 commits)
  [Editorial review] Add BiDi `network.setCacheBehavior` and `network.setExtraHeaders` pages (mdn#46140)
  build(deps-dev): bump @mdn/fred from 2.10.1 to 2.11.0 (mdn#46474)
  Reorder sections on HTML attribute pages (mdn#46483)
  Reorder sections on HTML element pages (mdn#46484)
  Fix live sample code block order in web API pages (mdn#46452)
  Move SVG attribute usage notes after examples (mdn#46458)
  Move SVG attribute elements section before examples (mdn#46459)
  Fix SuppressedError nesting in the `using` error handling example (mdn#46479)
  Editorial review: Document Web Audio render quantum size (mdn#46241)
  Remove the SVGAnimateColorElement page (mdn#46473)
  FF161 Relnote: Move WebTransport.anticipatedConcurrentIncoming{Uni|Bi}directionalStreams from 160 (mdn#46440)
  [WebExt] Screenshot updates to Nova (mdn#46270)
  build(deps-dev): bump cspell from 10.4.0 to 10.4.1 in the npm-dev group (mdn#46455)
  Update Firefox 160 release notes for WebDriver conforming changes. (mdn#46415)
  ci(deps): bump peter-evans/create-pull-request from 8.1.1 to 8.1.2 (mdn#46454)
  Move subtitles_en.vtt to shared-assets and update audio-video reference (mdn#46451)
  Yank Express Application Generator, migrate Express tutorial to ESM (mdn#45596)
  Fix heading sequence in web-api property pages (mdn#46450)
  Fix heading sequence in web-api interface pages (mdn#46448)
  Fix heading sequence in css-property pages (mdn#46447)
  ...

# Conflicts:
#	files/en-us/web/webdriver/reference/bidi/modules/network/index.md
#	files/sidebars/webdriver.yaml
pepelsbey added a commit to pepelsbey/mdn-content that referenced this pull request Nov 12, 2026
…epts

* upstream/main: (195 commits)
  [Editorial review] Add BiDi `network.setCacheBehavior` and `network.setExtraHeaders` pages (mdn#46140)
  build(deps-dev): bump @mdn/fred from 2.10.1 to 2.11.0 (mdn#46474)
  Reorder sections on HTML attribute pages (mdn#46483)
  Reorder sections on HTML element pages (mdn#46484)
  Fix live sample code block order in web API pages (mdn#46452)
  Move SVG attribute usage notes after examples (mdn#46458)
  Move SVG attribute elements section before examples (mdn#46459)
  Fix SuppressedError nesting in the `using` error handling example (mdn#46479)
  Editorial review: Document Web Audio render quantum size (mdn#46241)
  Remove the SVGAnimateColorElement page (mdn#46473)
  FF161 Relnote: Move WebTransport.anticipatedConcurrentIncoming{Uni|Bi}directionalStreams from 160 (mdn#46440)
  [WebExt] Screenshot updates to Nova (mdn#46270)
  build(deps-dev): bump cspell from 10.4.0 to 10.4.1 in the npm-dev group (mdn#46455)
  Update Firefox 160 release notes for WebDriver conforming changes. (mdn#46415)
  ci(deps): bump peter-evans/create-pull-request from 8.1.1 to 8.1.2 (mdn#46454)
  Move subtitles_en.vtt to shared-assets and update audio-video reference (mdn#46451)
  Yank Express Application Generator, migrate Express tutorial to ESM (mdn#45596)
  Fix heading sequence in web-api property pages (mdn#46450)
  Fix heading sequence in web-api interface pages (mdn#46448)
  Fix heading sequence in css-property pages (mdn#46447)
  ...

# Conflicts:
#	files/sidebars/webdriver.yaml
pepelsbey added a commit to pepelsbey/mdn-content that referenced this pull request Nov 12, 2026
…tication

* upstream/main: (186 commits)
  [Editorial review] Add BiDi `network.setCacheBehavior` and `network.setExtraHeaders` pages (mdn#46140)
  build(deps-dev): bump @mdn/fred from 2.10.1 to 2.11.0 (mdn#46474)
  Reorder sections on HTML attribute pages (mdn#46483)
  Reorder sections on HTML element pages (mdn#46484)
  Fix live sample code block order in web API pages (mdn#46452)
  Move SVG attribute usage notes after examples (mdn#46458)
  Move SVG attribute elements section before examples (mdn#46459)
  Fix SuppressedError nesting in the `using` error handling example (mdn#46479)
  Editorial review: Document Web Audio render quantum size (mdn#46241)
  Remove the SVGAnimateColorElement page (mdn#46473)
  FF161 Relnote: Move WebTransport.anticipatedConcurrentIncoming{Uni|Bi}directionalStreams from 160 (mdn#46440)
  [WebExt] Screenshot updates to Nova (mdn#46270)
  build(deps-dev): bump cspell from 10.4.0 to 10.4.1 in the npm-dev group (mdn#46455)
  Update Firefox 160 release notes for WebDriver conforming changes. (mdn#46415)
  ci(deps): bump peter-evans/create-pull-request from 8.1.1 to 8.1.2 (mdn#46454)
  Move subtitles_en.vtt to shared-assets and update audio-video reference (mdn#46451)
  Yank Express Application Generator, migrate Express tutorial to ESM (mdn#45596)
  Fix heading sequence in web-api property pages (mdn#46450)
  Fix heading sequence in web-api interface pages (mdn#46448)
  Fix heading sequence in css-property pages (mdn#46447)
  ...

# Conflicts:
#	files/sidebars/webdriver.yaml
pepelsbey added a commit to pepelsbey/mdn-content that referenced this pull request Nov 12, 2026
* upstream/main: (186 commits)
  [Editorial review] Add BiDi `network.setCacheBehavior` and `network.setExtraHeaders` pages (mdn#46140)
  build(deps-dev): bump @mdn/fred from 2.10.1 to 2.11.0 (mdn#46474)
  Reorder sections on HTML attribute pages (mdn#46483)
  Reorder sections on HTML element pages (mdn#46484)
  Fix live sample code block order in web API pages (mdn#46452)
  Move SVG attribute usage notes after examples (mdn#46458)
  Move SVG attribute elements section before examples (mdn#46459)
  Fix SuppressedError nesting in the `using` error handling example (mdn#46479)
  Editorial review: Document Web Audio render quantum size (mdn#46241)
  Remove the SVGAnimateColorElement page (mdn#46473)
  FF161 Relnote: Move WebTransport.anticipatedConcurrentIncoming{Uni|Bi}directionalStreams from 160 (mdn#46440)
  [WebExt] Screenshot updates to Nova (mdn#46270)
  build(deps-dev): bump cspell from 10.4.0 to 10.4.1 in the npm-dev group (mdn#46455)
  Update Firefox 160 release notes for WebDriver conforming changes. (mdn#46415)
  ci(deps): bump peter-evans/create-pull-request from 8.1.1 to 8.1.2 (mdn#46454)
  Move subtitles_en.vtt to shared-assets and update audio-video reference (mdn#46451)
  Yank Express Application Generator, migrate Express tutorial to ESM (mdn#45596)
  Fix heading sequence in web-api property pages (mdn#46450)
  Fix heading sequence in web-api interface pages (mdn#46448)
  Fix heading sequence in css-property pages (mdn#46447)
  ...

# Conflicts:
#	files/sidebars/webdriver.yaml
pepelsbey added a commit to pepelsbey/mdn-content that referenced this pull request Nov 12, 2026
…ollectors

* upstream/main: (186 commits)
  [Editorial review] Add BiDi `network.setCacheBehavior` and `network.setExtraHeaders` pages (mdn#46140)
  build(deps-dev): bump @mdn/fred from 2.10.1 to 2.11.0 (mdn#46474)
  Reorder sections on HTML attribute pages (mdn#46483)
  Reorder sections on HTML element pages (mdn#46484)
  Fix live sample code block order in web API pages (mdn#46452)
  Move SVG attribute usage notes after examples (mdn#46458)
  Move SVG attribute elements section before examples (mdn#46459)
  Fix SuppressedError nesting in the `using` error handling example (mdn#46479)
  Editorial review: Document Web Audio render quantum size (mdn#46241)
  Remove the SVGAnimateColorElement page (mdn#46473)
  FF161 Relnote: Move WebTransport.anticipatedConcurrentIncoming{Uni|Bi}directionalStreams from 160 (mdn#46440)
  [WebExt] Screenshot updates to Nova (mdn#46270)
  build(deps-dev): bump cspell from 10.4.0 to 10.4.1 in the npm-dev group (mdn#46455)
  Update Firefox 160 release notes for WebDriver conforming changes. (mdn#46415)
  ci(deps): bump peter-evans/create-pull-request from 8.1.1 to 8.1.2 (mdn#46454)
  Move subtitles_en.vtt to shared-assets and update audio-video reference (mdn#46451)
  Yank Express Application Generator, migrate Express tutorial to ESM (mdn#45596)
  Fix heading sequence in web-api property pages (mdn#46450)
  Fix heading sequence in web-api interface pages (mdn#46448)
  Fix heading sequence in css-property pages (mdn#46447)
  ...

# Conflicts:
#	files/sidebars/webdriver.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Learn Learning area docs (outside of one of the Learn:* subtags) size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants