Repository navigation
Move subtitles_en.vtt to shared-assets and update audio-video reference - #46451
Conversation
Josh-Cena
left a comment
There was a problem hiding this comment.
Instead of doing this, could you please remove the VTT file from content and add it to shared-assets? We added it here because tracks cannot be cross-origin. But I later realized that live samples support the /shared-assets/ reverse proxy which means this file can become same-origin.
Signed-off-by: Abdul karim mia <97598943+abdul-karim-mia@users.noreply.github.com>
a1c1d19 to
b3f642d
Compare
|
Updated! I opened mdn/shared-assets#106 to add \misc/subtitles_en.vtt, removed the VTT file from \mdn/content, reverted the \scripts/filecheck\ changes, and updated the live sample <track>\ reference to /shared-assets/misc/subtitles_en.vtt. Thank you! |
|
Preview URLs (1 page) (comment last updated: 2026-11-10 10:09:53) |
chrisdavidmills
left a comment
There was a problem hiding this comment.
@abdul-karim-mia, a couple of comments for you; thanks for working on this.
Of course, we need to wait for the shared-assets update to be live before merging this.
Signed-off-by: Abdul karim mia <97598943+abdul-karim-mia@users.noreply.github.com>
|
mdn/shared-assets#106 has just been merged upstream. Ready for review whenever you have a moment! Thank you. |
chrisdavidmills
left a comment
There was a problem hiding this comment.
OK, LGTM. Thanks again, @abdul-karim-mia.
* upstream/main: (204 commits) [Editorial review] Add BiDi `network.setCacheBehavior` and `network.setExtraHeaders` pages (mdn#46140) build(deps-dev): bump @mdn/fred from 2.10.1 to 2.11.0 (mdn#46474) Reorder sections on HTML attribute pages (mdn#46483) Reorder sections on HTML element pages (mdn#46484) Fix live sample code block order in web API pages (mdn#46452) Move SVG attribute usage notes after examples (mdn#46458) Move SVG attribute elements section before examples (mdn#46459) Fix SuppressedError nesting in the `using` error handling example (mdn#46479) Editorial review: Document Web Audio render quantum size (mdn#46241) Remove the SVGAnimateColorElement page (mdn#46473) FF161 Relnote: Move WebTransport.anticipatedConcurrentIncoming{Uni|Bi}directionalStreams from 160 (mdn#46440) [WebExt] Screenshot updates to Nova (mdn#46270) build(deps-dev): bump cspell from 10.4.0 to 10.4.1 in the npm-dev group (mdn#46455) Update Firefox 160 release notes for WebDriver conforming changes. (mdn#46415) ci(deps): bump peter-evans/create-pull-request from 8.1.1 to 8.1.2 (mdn#46454) Move subtitles_en.vtt to shared-assets and update audio-video reference (mdn#46451) Yank Express Application Generator, migrate Express tutorial to ESM (mdn#45596) Fix heading sequence in web-api property pages (mdn#46450) Fix heading sequence in web-api interface pages (mdn#46448) Fix heading sequence in css-property pages (mdn#46447) ... # Conflicts: # files/en-us/web/webdriver/reference/bidi/modules/network/index.md # files/sidebars/webdriver.yaml
…epts * upstream/main: (195 commits) [Editorial review] Add BiDi `network.setCacheBehavior` and `network.setExtraHeaders` pages (mdn#46140) build(deps-dev): bump @mdn/fred from 2.10.1 to 2.11.0 (mdn#46474) Reorder sections on HTML attribute pages (mdn#46483) Reorder sections on HTML element pages (mdn#46484) Fix live sample code block order in web API pages (mdn#46452) Move SVG attribute usage notes after examples (mdn#46458) Move SVG attribute elements section before examples (mdn#46459) Fix SuppressedError nesting in the `using` error handling example (mdn#46479) Editorial review: Document Web Audio render quantum size (mdn#46241) Remove the SVGAnimateColorElement page (mdn#46473) FF161 Relnote: Move WebTransport.anticipatedConcurrentIncoming{Uni|Bi}directionalStreams from 160 (mdn#46440) [WebExt] Screenshot updates to Nova (mdn#46270) build(deps-dev): bump cspell from 10.4.0 to 10.4.1 in the npm-dev group (mdn#46455) Update Firefox 160 release notes for WebDriver conforming changes. (mdn#46415) ci(deps): bump peter-evans/create-pull-request from 8.1.1 to 8.1.2 (mdn#46454) Move subtitles_en.vtt to shared-assets and update audio-video reference (mdn#46451) Yank Express Application Generator, migrate Express tutorial to ESM (mdn#45596) Fix heading sequence in web-api property pages (mdn#46450) Fix heading sequence in web-api interface pages (mdn#46448) Fix heading sequence in css-property pages (mdn#46447) ... # Conflicts: # files/sidebars/webdriver.yaml
…tication * upstream/main: (186 commits) [Editorial review] Add BiDi `network.setCacheBehavior` and `network.setExtraHeaders` pages (mdn#46140) build(deps-dev): bump @mdn/fred from 2.10.1 to 2.11.0 (mdn#46474) Reorder sections on HTML attribute pages (mdn#46483) Reorder sections on HTML element pages (mdn#46484) Fix live sample code block order in web API pages (mdn#46452) Move SVG attribute usage notes after examples (mdn#46458) Move SVG attribute elements section before examples (mdn#46459) Fix SuppressedError nesting in the `using` error handling example (mdn#46479) Editorial review: Document Web Audio render quantum size (mdn#46241) Remove the SVGAnimateColorElement page (mdn#46473) FF161 Relnote: Move WebTransport.anticipatedConcurrentIncoming{Uni|Bi}directionalStreams from 160 (mdn#46440) [WebExt] Screenshot updates to Nova (mdn#46270) build(deps-dev): bump cspell from 10.4.0 to 10.4.1 in the npm-dev group (mdn#46455) Update Firefox 160 release notes for WebDriver conforming changes. (mdn#46415) ci(deps): bump peter-evans/create-pull-request from 8.1.1 to 8.1.2 (mdn#46454) Move subtitles_en.vtt to shared-assets and update audio-video reference (mdn#46451) Yank Express Application Generator, migrate Express tutorial to ESM (mdn#45596) Fix heading sequence in web-api property pages (mdn#46450) Fix heading sequence in web-api interface pages (mdn#46448) Fix heading sequence in css-property pages (mdn#46447) ... # Conflicts: # files/sidebars/webdriver.yaml
* upstream/main: (186 commits) [Editorial review] Add BiDi `network.setCacheBehavior` and `network.setExtraHeaders` pages (mdn#46140) build(deps-dev): bump @mdn/fred from 2.10.1 to 2.11.0 (mdn#46474) Reorder sections on HTML attribute pages (mdn#46483) Reorder sections on HTML element pages (mdn#46484) Fix live sample code block order in web API pages (mdn#46452) Move SVG attribute usage notes after examples (mdn#46458) Move SVG attribute elements section before examples (mdn#46459) Fix SuppressedError nesting in the `using` error handling example (mdn#46479) Editorial review: Document Web Audio render quantum size (mdn#46241) Remove the SVGAnimateColorElement page (mdn#46473) FF161 Relnote: Move WebTransport.anticipatedConcurrentIncoming{Uni|Bi}directionalStreams from 160 (mdn#46440) [WebExt] Screenshot updates to Nova (mdn#46270) build(deps-dev): bump cspell from 10.4.0 to 10.4.1 in the npm-dev group (mdn#46455) Update Firefox 160 release notes for WebDriver conforming changes. (mdn#46415) ci(deps): bump peter-evans/create-pull-request from 8.1.1 to 8.1.2 (mdn#46454) Move subtitles_en.vtt to shared-assets and update audio-video reference (mdn#46451) Yank Express Application Generator, migrate Express tutorial to ESM (mdn#45596) Fix heading sequence in web-api property pages (mdn#46450) Fix heading sequence in web-api interface pages (mdn#46448) Fix heading sequence in css-property pages (mdn#46447) ... # Conflicts: # files/sidebars/webdriver.yaml
…ollectors * upstream/main: (186 commits) [Editorial review] Add BiDi `network.setCacheBehavior` and `network.setExtraHeaders` pages (mdn#46140) build(deps-dev): bump @mdn/fred from 2.10.1 to 2.11.0 (mdn#46474) Reorder sections on HTML attribute pages (mdn#46483) Reorder sections on HTML element pages (mdn#46484) Fix live sample code block order in web API pages (mdn#46452) Move SVG attribute usage notes after examples (mdn#46458) Move SVG attribute elements section before examples (mdn#46459) Fix SuppressedError nesting in the `using` error handling example (mdn#46479) Editorial review: Document Web Audio render quantum size (mdn#46241) Remove the SVGAnimateColorElement page (mdn#46473) FF161 Relnote: Move WebTransport.anticipatedConcurrentIncoming{Uni|Bi}directionalStreams from 160 (mdn#46440) [WebExt] Screenshot updates to Nova (mdn#46270) build(deps-dev): bump cspell from 10.4.0 to 10.4.1 in the npm-dev group (mdn#46455) Update Firefox 160 release notes for WebDriver conforming changes. (mdn#46415) ci(deps): bump peter-evans/create-pull-request from 8.1.1 to 8.1.2 (mdn#46454) Move subtitles_en.vtt to shared-assets and update audio-video reference (mdn#46451) Yank Express Application Generator, migrate Express tutorial to ESM (mdn#45596) Fix heading sequence in web-api property pages (mdn#46450) Fix heading sequence in web-api interface pages (mdn#46448) Fix heading sequence in css-property pages (mdn#46447) ... # Conflicts: # files/sidebars/webdriver.yaml
Description
Removes \subtitles_en.vtt\ from \mdn/content\ and points the \ est_your_skills/audio_and_video\ live sample track to /shared-assets/misc/subtitles_en.vtt.
Motivation
As requested by @Josh-Cena in review, \subtitles_en.vtt\ is moved to \mdn/shared-assets\ (PR mdn/shared-assets#106) so that it can be served via the same-origin /shared-assets/\ reverse proxy rather than living in the content repository.
Additional details
Related issues and pull requests