Skip to content

🤖 AI: Fix to Accept PKCS#1 Pub Keys - #46

Merged
ejinotti-mdsol merged 5 commits into
mainfrom
fix/accept-pkcs1-public-keys
Jul 21, 2026
Merged

ejinotti-mdsol merged 5 commits into
mainfrom
fix/accept-pkcs1-public-keys

Conversation

@ejinotti-mdsol

Copy link
Copy Markdown
Contributor

Summary

  • accept RSA public keys encoded as either SubjectPublicKeyInfo or PKCS#1 PEM
  • preserve the existing PublicKeyDecodeError API for malformed public keys
  • add public-only regression tests for both supported encodings
  • release the fix as mauth-core 0.6.1

Why

MAuth registrations can contain PKCS#1 public keys using the
BEGIN RSA PUBLIC KEY envelope.

Verifier::new previously used only from_public_key_pem, which accepts
SubjectPublicKeyInfo keys using the BEGIN PUBLIC KEY envelope. Consequently,
otherwise valid PKCS#1 registrations failed during key loading and surfaced as
KeyUnavailable before signature verification.

Testing

  • cargo fmt --all -- --check
  • cargo clippy --all-targets --all-features
  • cargo test --verbose
  • cargo bench
  • cargo publish --dry-run --allow-dirty
  • git diff --check

johnduhart
johnduhart previously approved these changes Jul 20, 2026
@ejinotti-mdsol

Copy link
Copy Markdown
Contributor Author

@ykitamura-mdsol FYI

@ykitamura-mdsol ykitamura-mdsol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@ejinotti-mdsol
ejinotti-mdsol merged commit aba0a9e into main Jul 21, 2026
8 checks passed
@ejinotti-mdsol
ejinotti-mdsol deleted the fix/accept-pkcs1-public-keys branch July 21, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants