Repository navigation
🤖 AI: Fix to Accept PKCS#1 Pub Keys - #46
Merged
Merged
Conversation
johnduhart
previously approved these changes
Jul 20, 2026
Contributor
Author
|
@ykitamura-mdsol FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PublicKeyDecodeErrorAPI for malformed public keysmauth-core0.6.1Why
MAuth registrations can contain PKCS#1 public keys using the
BEGIN RSA PUBLIC KEYenvelope.Verifier::newpreviously used onlyfrom_public_key_pem, which acceptsSubjectPublicKeyInfo keys using the
BEGIN PUBLIC KEYenvelope. Consequently,otherwise valid PKCS#1 registrations failed during key loading and surfaced as
KeyUnavailablebefore signature verification.Testing
cargo fmt --all -- --checkcargo clippy --all-targets --all-featurescargo test --verbosecargo benchcargo publish --dry-run --allow-dirtygit diff --check