Repository navigation
Windows getURI error fix - #340
Open
sudhanshu-raj wants to merge 1 commit into
Open
sudhanshu-raj wants to merge 1 commit into
sudhanshu-raj wants to merge 1 commit into
Conversation
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This error which is URISyntaxException occurs on Windows, because when we scan and find the jar for initializer module it returns the path including backslash() and when we calling
getURI()which ends on creating new URI object and because due to opaque URI scheme\are not allowed in the file path likeC:\Users\test\.m2\repository\org\openmrs\module\initializer-api\2.12.0\initializer-api-2.12.0.jar!/messages.propertiesand that's where it throws error.This was hidden from initializer test cases because module test against the
target/dir and it generated forward slashes(/) for those paths that's why no error but this error cause of another module try to access and do same because then it access those files form direct m2 local folder.