Repository navigation
Conversation
The cassettes were recorded in fae7db0, but the vcr markers never made it into that commit, so these tests have been hitting the live API ever since, AddConnectedPage included. The connected page URL was timestamped, so it could never match its cassette either; it's now fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link analysis cassettes were recorded back in fae7db0, but the
@pytest.mark.vcrmarkers never made it into that commit. So these tests have been calling the live API on every run since — includingAddConnectedPage, which writes to whatever siteBING_WEBMASTER_TEST_SITEpoints at.Adding the markers is enough for 10 of the 11 tests. The connected page test built its URL from a timestamp, so it could never match its cassette; it now uses a fixed URL, with the matching request line in the cassette updated. Nothing was re-recorded and the recorded response is untouched.
Tested with a dummy API key, so anything still reaching Bing fails loudly: the link analysis tests now pass, where before they failed with
InvalidApiKey.