Take the shard count and identify concurrency from Discord by default - #263
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both now default to whatever Discord recommends for the bot rather than being hardcoded. shard_count = 0 asks for the recommended count, so a self hoster configures nothing and a growing bot doesn't outgrow a number someone wrote down once. identify_concurrency = 0 uses what Discord granted.
identify_concurrency is new and only goes down. Discord's grant is a hard ceiling, but lowering it spreads the GUILD_CREATE burst at startup over more time, which is the lever when the process is CPU bound while all the shards come up. Tonight's profile had all 8 cores saturated at the point the first shards went zombie.
One REST call at boot when either is unset, and both are logged along with the remaining session budget.