Skip to content

Support merge-before-filter compaction (#15517) #15517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xingbowang wants to merge 1 commit into from
Closed

Support merge-before-filter compaction (#15517) #15517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion db/builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,13 @@ Status BuildTable(
context.reason = tboptions.reason;
compaction_filter =
ioptions.compaction_filter_factory->CreateCompactionFilter(context);
CompactionFilter::MergeOrder order;
s = GetCompactionFilterMergeOrder(
compaction_filter.get(), ioptions.compaction_filter_factory.get(),
tboptions.reason, &order);
if (!s.ok()) {
return s;
}
if (compaction_filter != nullptr &&
!compaction_filter->IgnoreSnapshots()) {
s.PermitUncheckedError();
Expand Down Expand Up @@ -217,7 +224,8 @@ Status BuildTable(
auto ucmp = tboptions.internal_comparator.user_comparator();
MergeHelper merge(
env, ucmp, ioptions.merge_operator.get(), compaction_filter.get(),
ioptions.logger, true /* internal key corruption is not ok */,
CompactionFilter::MergeOrder::kFilterBeforeMerge, ioptions.logger,
true /* internal key corruption is not ok */,
snapshots.empty() ? 0 : snapshots.back(), snapshot_checker);

std::unique_ptr<BlobFileBuilder> blob_file_builder(
Expand Down
Loading
Loading