Conversation
The operator gets the `operator.logHeadersAndProperties` Helm value. When it is `false`, the `Message Processing` logs do not have the `request_headers` and `message_properties` fields. Tell users about it in the field tables and in the warning about sensitive values.
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can keep summaries lean with Findings visible per group, which tucks the rest behind a View link |
|
[Low risk] Documents an existing logging configuration option. The PR appears safe to merge after the stated Operator release, with two non-blocking documentation clarifications.
|
PR Summary by QodoDocument optional header and message-property logging
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
meowjesty
left a comment
There was a problem hiding this comment.
Phrasing can be better, it's a bit confusing.
The operator change flipped the option. It is now `operator.hideHeadersAndProperties`, with the default `false`.
For COR-1961, operator change: metalbear-co/operator#2551.
The
Message Processinglogs write all HTTP request headers and all queue message properties, and these can contain secrets. The operator chart gets theoperator.logHeadersAndPropertiesvalue. When it isfalse, the logs do not have therequest_headersandmessage_propertiesfields, but they still have the trace and correlation fields.The monitoring page lists these two fields as always present, and its warning about sensitive values only suggests redaction in the log collector. This updates the two field rows, and adds the option to the warning, so that users who read about the risk also find the way to turn it off.
Merge this only after the operator release that has the change.
#399 (COR-1962) also changes the same warning on this page, so the second of the two PRs to merge will need a small rebase.