Agent-Started Trials: Document mirrord operator uninstall - #403
Conversation
`mirrord operator install` gets `--context`, a confirmation prompt that `--yes` skips, and a companion `mirrord operator uninstall`. The retry after a failed trial installation now removes what was installed first. The page also said that the command sends the kubecontext name as the cluster hint, but it sends the cluster ID.
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all |
PR Summary by QodoDocument Operator uninstall and agent-started trial recovery
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
|
[Low risk] Documents agent-started trial workflow and operator commands. The PR should not merge until its retry guidance preserves the selected kubecontext, in addition to the stated mirrord release prerequisite.
|
The retry after a failed or stopped trial installation must use the same kubecontext as the first attempt, and the command prints the steps only when the installation fails. The page now states the steps directly, with `--context`. It also says that the cluster ID is sent only when the command can read it.
ed510d2 to
b8fadfc
Compare
Problem
Documents COR-1970 and COR-1969 for the Agent-Started Trials page that #396 adds, so this PR is based on its branch.
The mirrord PRs metalbear-co/mirrord#4989 and metalbear-co/mirrord#4990 change
mirrord operator installand addmirrord operator uninstall:--contextinstalls into a different kubecontext.--yesskips the question, and it does not ask without a terminal.mirrord operator uninstallremoves what the installation created, also after an installation that failed half-way.--api-keyalone fails, because the failed installation left objects behind. The command now prints two steps:mirrord operator uninstall, thenmirrord operator install --api-key <key>.The page also says that the command sends the name of the current kubecontext as the cluster hint. It sends the cluster ID (the UID of the
defaultnamespace), because a kubecontext name can contain account details, for example the AWS account ID in an EKS context name.Change
--context, the confirmation prompt and--yes, the new retry steps, the cluster ID as the default cluster hint, and that the "already installed" and "leftover objects" errors point tomirrord operator uninstall.mirrord operator uninstall: it lets the Operator end its sessions first, then deletes everything the installation created, including the CRDs and so the mirrord policies and profiles. It takes--contextand--yestoo. An installation that was moved to Helm is removed withhelm uninstall.This must not merge before a mirrord release that has #4989 and #4990.
Testing
I checked each statement against the CLI code in the mirrord PRs, and I ran the commands on a kind cluster while I tested those PRs.