Repository navigation
Validate universe scope in imported inductive and constructor types - #121
Draft
heathsanchez wants to merge 3 commits into
Draft
heathsanchez wants to merge 3 commits into
heathsanchez wants to merge 3 commits into
Conversation
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Independently scoped soundness guard (qualification pending)
The published Flash checker constructs the inductive-block verifier without an active
DeclarInfo. That leaves universe parameters in imported inductive and constructor types outside the ordinary declaration scope check. As described in nanoda_lib issue #79, an invalid inductiveU : Sort uwithlevelParams: []can be accepted, and a later declaration can accidentally bindu.This branch performs an iterative, source-derived DAG walk over each original inductive and constructor type, requiring every universe level in
SortandConstnodes to use only that declaration's exported universe parameters. It does not rely on a list of trusted names, cached verdicts or a special case forU.The included GitHub Actions qualification builds the exact published Flash SHA
78c7502bac8a5ba000057b3f083bc0595ac65750and candidate with matched configuration and CPU flags; it requires the official Arenaother/inductive-undeclared-universecase to change ACCEPT → REJECT, with unchanged verdicts for all other downloaded non-performance small cases. Artifacts preserve the source, binary and test archive hashes.This is a distinct candidate from draft PR #120, which patches nested recursor field-count validation. Keep DRAFT until protected results, full Mathlib, and performance are reconciled. No release or leaderboard claim.