Skip to content
This repository was archived by the owner on Feb 26, 2021. It is now read-only.

re-enable unit and full-app tests - #172

Open
noahsw wants to merge 7 commits into
meteor:masterfrom
noahsw:enable-tests
Open

re-enable unit and full-app tests#172
noahsw wants to merge 7 commits into
meteor:masterfrom
noahsw:enable-tests

Conversation

@noahsw

@noahsw noahsw commented Aug 5, 2016

Copy link
Copy Markdown

Tests were removed from CI in #164 but they're working fine for me on master so we should add them back.

Open question is whether we should be running meteor npm install or npm install, but let's see if CI passes.

@mrmowgli

Copy link
Copy Markdown

How did you get the file permissions to work on circlecl? I'm trying to update the tests in the coffeescript branch, and am running into this. I assume I should be modifying the pre section of the circle.yml?

@hwillson hwillson self-assigned this Sep 16, 2016
@hwillson

Copy link
Copy Markdown
Contributor

Hi @noahsw - thanks for the PR. Are you still working on this? Let me know if you are, or if you'd like me to take a look.

@noahsw

noahsw commented Sep 19, 2016

Copy link
Copy Markdown
Author

Hi @hwillson - sorry I ran into CI problems and had to take a break. Maybe this is why the tests were removed in the first place... I hope someone can figure it out though!

@hwillson

Copy link
Copy Markdown
Contributor

No problem @noahsw - I'll take a look. Thanks again!

@GeoffreyBooth

Copy link
Copy Markdown
Contributor

See also #210

@hwillson hwillson removed their assignment Apr 11, 2017
@CLAassistant

CLAassistant commented Oct 7, 2019

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ noahsw
❌ DominikGuzei
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants