Skip to content

Fix flaky test_wins by seeding DDMC and GMM - #574

Merged
aarmey merged 1 commit into
mainfrom
fix-flaky-test-wins
Nov 14, 2026
Merged

aarmey merged 1 commit into
mainfrom
fix-flaky-test-wins

Conversation

@aarmey

@aarmey aarmey commented Nov 14, 2026

Copy link
Copy Markdown
Member

CI failures on #571 and #572, and an earlier run on the expand-kinome-pspls branch, all came from test_cluster.py::test_wins. It fits an unseeded DDMC and an unseeded GaussianMixture and requires their cluster centers to match with cosine similarity > 0.95. Across 30 seeds, 2 (about 7%) fail because one model lands in a poor local optimum. That also explains why push runs pass while PR runs on the same code fail.

This PR sets random_state=0 on both models, which is a passing seed, so the test is deterministic. Only the test changes. Ruff lint and format are clean, and test_cluster.py passes locally (30 passed). No other failures turned up in the recent runs.

@aarmey
aarmey merged commit 6982d95 into main Nov 14, 2026
2 checks passed
@aarmey
aarmey deleted the fix-flaky-test-wins branch November 14, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant