Repository navigation
Require Python 3.13, drop unused dependencies, update lockfile - #575
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires-python, ruff target, ty environment, docs).IterativeSVDinfigureM2.impute_pca. It is replaced by a short numpy iterative-SVD routine with the same defaults (zero init, gradual rank increase, 200 iterations max, 1e-5 tolerance). This also drops cvxpy, cvxopt, knnimpute and nose from the install.scikit-learnfloor to 1.8 andpytest-covto 7.x. Refreshuv.lockwithuv lock --upgrade.tyignore ruleinvalid-method-overridetoincompatible-method-override, as the newer ty warns about it.Checked locally: ruff, ruff format and ty are clean, and pytest passes (89 passed). A synthetic rank-3 matrix with 20% of entries missing is recovered to a mean absolute error of about 3e-5 by the new
impute_pca, and observed entries are left unchanged. I did not compare against fancyimpute's output directly.