Repository navigation
to_gpu: repair in-run index order at upload (#87) - #99
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting within value-runs is a no-op on arrays built normally (indices are already ascending per run), but
VCSC[perm_rows]silently breaks it. This adds a one-pass check at upload and a key sort only when needed, plus tests pinning the invariant across construction/selection paths.Measured on RTX 5080, VCSC 60,000x2,000 at 20% density after a row permutation,
B @ VCSC: width 1 660→144 µs (4.6x), width 2 643→228 µs (2.8x), width 4 664→425 µs (1.6x). Already-canonical arrays pay only the check (~0.2–0.8 ms at 5–24M nnz).Closes #87. Also tightens the docstring wording (ascending within runs, not across).