Repository navigation
Add addslash bool to SRA interleave command - #84
Merged
Merged
Conversation
Contributor
Author
|
tested directly with sra that failed in prev tests SRR28003281 |
samobermiller
marked this pull request as ready for review
September 17, 2026 21:12
aclum
approved these changes
Sep 18, 2026
aclum
left a comment
aclum
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just a note that we need to make sure to update the workflows.yaml with this new sra boolean.
Contributor
Author
The boolean isn't a new parameter for rqcfilter, its defined within the wdl using the existing accessions parameter. so I don't think this needs to be added to the workflows.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add addslash=t to interleave command for sra data so read information is preserved in header