Updates browserlist by pumping safari to 16.4 due to required SIMD bu… - #46
Conversation
|
Warning Review limit reached
Next review available in: 5 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
📝 WalkthroughWalkthroughSafari minimum support was raised from 15.1 to 16.4 in six package ChangesSafari support alignment
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/repo-utils/browser-support.test.mts (1)
91-92: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove the no-op string replacement.
The fixture already contains
iOS Safari 16.4, so replacing it with the identical value has no effect and triggered CodeQL. PassbrowserSupportReadmedirectly instead.Proposed fix
- browserSupportReadme.replace("iOS Safari 16.4", "iOS Safari 16.4"), + browserSupportReadme,🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/repo-utils/browser-support.test.mts` around lines 91 - 92, Remove the no-op replace call in the browser support test and pass browserSupportReadme directly to the surrounding assertion or operation, preserving the existing fixture value and behavior.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/repo-utils/browser-support.test.mts`:
- Around line 91-92: Remove the no-op replace call in the browser support test
and pass browserSupportReadme directly to the surrounding assertion or
operation, preserving the existing fixture value and behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: b56f21bf-afa1-4989-93ee-0d17cc9db43f
📒 Files selected for processing (13)
packages/blinkcard-core/README.mdpackages/blinkcard-core/package.jsonpackages/blinkcard-worker/README.mdpackages/blinkcard-worker/package.jsonpackages/blinkid-core/README.mdpackages/blinkid-core/package.jsonpackages/blinkid-verify-core/README.mdpackages/blinkid-verify-core/package.jsonpackages/blinkid-verify-worker/README.mdpackages/blinkid-verify-worker/package.jsonpackages/blinkid-worker/README.mdpackages/blinkid-worker/package.jsonpackages/repo-utils/browser-support.test.mts
nnstanusic
left a comment
nnstanusic
left a comment
There was a problem hiding this comment.
Lgtm: Resolve the substring replace, and CI.
ab90572 to
9051d9c
Compare
9051d9c to
226c0f9
Compare
mariokresic
left a comment
mariokresic
left a comment
There was a problem hiding this comment.
Firefox on wasm also changed with basic removal
4 participants
…ilds
Summary by CodeRabbit
Documentation
Compatibility
Tests