Remove print(key) that leaks secret value to pipeline logs - #196
Open
Manya Sharma (ManyaS-Git) wants to merge 1 commit into
Open
Remove print(key) that leaks secret value to pipeline logs#196Manya Sharma (ManyaS-Git) wants to merge 1 commit into
Manya Sharma (ManyaS-Git) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ci/scripts/set_secret.pyprints the raw value ofstorage_conn_string(line 33:print(key)) to stdout before storing it in Azure Key Vault. Because the script is invoked by.ci/steps/deploy_steps.yml:65and.ci/steps/deploy_steps_v2.yml:77, the secret value is captured in the Azure DevOps pipeline build log — visible to anyone with access to the run.The
print()is debug output; the function's own return message (print(message)on line 36) already confirms success. Removing the single line eliminates the leak with no change to the script's function.Verification
py_compile.-n <key-name>via the inline script indeploy_steps.yml; the removed line is standalone with no downstream dependency.microsoft/AImaster.