Fix Cross-platform LTS upgrade checkout on reused runners - #8479
Merged
Merged
Conversation
The test-upgrade job runs directly on a reused VMSS runner. When it lands on the VM that just ran the Azure Linux 3 build-install job of the same run, which checks out CCF as root inside its container, actions/checkout fails with permission errors on the root-owned workspace. This broke the last two weekly runs on main. Restore ownership of the workspace to the runner user before checking out. The step is identical to the one in #8282, where it was validated. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Amaury Chamayou (achamayou)
October 1, 2026 09:51
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused CI fix is documented and validated by a successful workflow run on a reused runner.
Review effort: Balanced
Findings: None
What changed in this PR
Restores checkout reliability on reused VMSS runners by correcting workspace ownership before the LTS upgrade job.
Changes:
- Adds a pre-checkout recursive ownership restoration step.
- Documents why reused runners require this cleanup.
Custom instructions used: .github/copilot-instructions.md, .github/instructions/reviewing.instructions.md
| File | Description |
|---|---|
.github/workflows/cross-platform-lts.yml |
Restores workspace ownership before checkout. |
.github/workflows/README.md |
Documents the reused-runner permission issue. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Max (maxtropets)
approved these changes
Oct 1, 2026
Amaury Chamayou (achamayou)
enabled auto-merge (squash)
October 1, 2026 13:02
Amaury Chamayou (achamayou)
disabled auto-merge
October 1, 2026 13:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The weekly Cross-platform LTS workflow failed on
mainin both of its last scheduled runs (2026-09-20, 2026-09-27) and on #8477, always in theactions/checkoutstep of theUpgrade ... AL3 to ... AL4job:In every failing run,
test-upgraderan on the same VM as the Azure Linux 3build-installjob of that run (runners30999b0ec_*,27b3f7d4c_*,c6bb2e77c_*). That job checks out CCF as root inside its--user rootcontainer, andtest-upgradethen runs directly on the reused host as the runner user, so it cannot clean or update the root-owned checkout.Implementation summary
sudo chown -R "$(id -u):$(id -g)" "$GITHUB_WORKSPACE") before checkout intest-upgrade, and document why in.github/workflows/README.md.test-upgradelanded on the VM that had just run the root-container build and passed.image_digestinrelease.yml, does not check out the repository.test-upgrade;prettier --checkpasses on both changed files. This PR triggers Cross-platform LTS through itspathsfilter.Safety and compatibility
CI-only change with no runtime, API, or data-format impact. The new step only changes ownership of files inside the job's own workspace on the runner.