Skip to content

TEST: Restore renamed notebook exclusion#2254

Merged
romanlutz merged 2 commits into
microsoft:mainfrom
romanlutz:romanlutz-skip-renamed-notebook
Jul 22, 2026
Merged

TEST: Restore renamed notebook exclusion#2254
romanlutz merged 2 commits into
microsoft:mainfrom
romanlutz:romanlutz-skip-renamed-notebook

Conversation

@romanlutz

@romanlutz romanlutz commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • restore the non-LLM target notebook exclusion under its current 8_non_llm_targets name in integration tests and docs generation
  • update other renamed generator exclusions for Playwright and the consolidated XPIA workflow
  • remove exclusions for deleted notebooks and replace orphaned #4001 references with self-contained requirements

Testing

  • uv run pytest tests\integration\targets\test_entra_auth_targets.py::test_video_target_entra_auth tests\integration\targets\test_entra_auth_targets.py::test_video_target_remix_entra_auth -q
  • uv run pytest tests\integration\targets\test_notebooks_targets.py tests\integration\memory\test_notebooks_memory.py tests\integration\score\test_scorer_notebooks.py --collect-only -q
  • uv run ruff check doc\generate_docs\pct_to_ipynb.py tests\integration\memory\test_notebooks_memory.py tests\integration\score\test_scorer_notebooks.py tests\integration\targets\test_notebooks_targets.py

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 77134999-55ec-4959-ba0b-e5eb331ec87a
Copilot AI review requested due to automatic review settings July 22, 2026 15:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores and cleans up notebook-execution integration test exclusions so the notebook test suite reflects the current set of notebooks under doc/code/.

Changes:

  • Add 8_non_llm_targets.ipynb back to the excluded notebooks list for target notebooks.
  • Remove the stale exclusion list in scorer notebooks (previously referenced a deleted notebook) by setting skipped_files to empty.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/integration/targets/test_notebooks_targets.py Re-adds an exclusion for the renamed/non-runnable target notebook.
tests/integration/score/test_scorer_notebooks.py Removes a stale notebook exclusion by resetting the skip list to empty.

Comment thread tests/integration/targets/test_notebooks_targets.py Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 77134999-55ec-4959-ba0b-e5eb331ec87a
Copilot AI review requested due to automatic review settings July 22, 2026 17:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@romanlutz
romanlutz added this pull request to the merge queue Jul 22, 2026
Merged via the queue into microsoft:main with commit 9b0da71 Jul 22, 2026
53 checks passed
@romanlutz
romanlutz deleted the romanlutz-skip-renamed-notebook branch July 22, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants