TEST: Restore renamed notebook exclusion#2254
Merged
romanlutz merged 2 commits intoJul 22, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 77134999-55ec-4959-ba0b-e5eb331ec87a
Contributor
There was a problem hiding this comment.
Pull request overview
Restores and cleans up notebook-execution integration test exclusions so the notebook test suite reflects the current set of notebooks under doc/code/.
Changes:
- Add
8_non_llm_targets.ipynbback to the excluded notebooks list for target notebooks. - Remove the stale exclusion list in scorer notebooks (previously referenced a deleted notebook) by setting
skipped_filesto empty.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/integration/targets/test_notebooks_targets.py | Re-adds an exclusion for the renamed/non-runnable target notebook. |
| tests/integration/score/test_scorer_notebooks.py | Removes a stale notebook exclusion by resetting the skip list to empty. |
hannahwestra25
approved these changes
Jul 22, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 77134999-55ec-4959-ba0b-e5eb331ec87a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
8_non_llm_targetsname in integration tests and docs generation#4001references with self-contained requirementsTesting
uv run pytest tests\integration\targets\test_entra_auth_targets.py::test_video_target_entra_auth tests\integration\targets\test_entra_auth_targets.py::test_video_target_remix_entra_auth -quv run pytest tests\integration\targets\test_notebooks_targets.py tests\integration\memory\test_notebooks_memory.py tests\integration\score\test_scorer_notebooks.py --collect-only -quv run ruff check doc\generate_docs\pct_to_ipynb.py tests\integration\memory\test_notebooks_memory.py tests\integration\score\test_scorer_notebooks.py tests\integration\targets\test_notebooks_targets.py