Skip to content

fix(sleep): skip assistant.message events with non-dict data - #232

Open
pravit-amp wants to merge 1 commit into
microsoft:mainfrom
pravit-amp:fix/sleep-copilot-jsonl-nondict-data
Open

fix(sleep): skip assistant.message events with non-dict data#232
pravit-amp wants to merge 1 commit into
microsoft:mainfrom
pravit-amp:fix/sleep-copilot-jsonl-nondict-data

Conversation

@pravit-amp

Copy link
Copy Markdown

Closes #231

Problem

CopilotCliBackend._parse_jsonl_response treated the data field of an assistant.message event as an object:

content = (obj.get("data") or {}).get("content")

A truthy non-dict value ("text", 5, a non-empty list) raises AttributeError on the field access. That happens outside the per-line try, which only wraps json.loads, so a single malformed line aborts the parse of the whole stream and the backend returns nothing for that call. data: [] slipped through only because [] or {} falls back to {}.

Fix

Port the guard that skillopt/model/copilot_backend.py::parse_copilot_jsonl already applies to the same event format:

data = obj.get("data")
if not isinstance(data, dict):
    continue
content = data.get("content")

That guard landed in 5497a31 ("harden and deduplicate JSONL parsing"), which removed this exact line from copilot_backend.py and codex_harness.py and folded all three copies into one helper. skillopt_sleep/backend.py predates it and was left behind, since the sleep package deliberately keeps zero dependency on the research package.

I kept the vendored copy rather than importing the shared helper, to preserve that decoupling. The docstring now records the relationship and asks for the two to be kept in sync, matching how skillopt_sleep/gate.py documents its own vendoring of the validation gate.

One intentional difference from the research-package copy: the wider except (ValueError, RecursionError, TypeError) stays. json.loads raises RecursionError, not JSONDecodeError, on a deeply nested payload, so narrowing it to match would reintroduce a crash the sleep copy already handles. The docstring calls this out so it does not read as accidental drift.

Tests

Added two focused cases to TestCopilotBackend:

  • test_parse_jsonl_skips_non_dict_data_without_losing_stream places a bad data value between two good messages and asserts "first\nsecond" still comes through, so a malformed event costs only its own line. Runs as subtests over "text", 5, [1,2] and true. This mirrors the existing coverage in tests/test_copilot_exec_backend.py for the research-package parser.
  • test_parse_jsonl_ignores_non_object_top_level covers non-object top-level lines.

This also fixes the pre-existing failure in test_parse_jsonl_ignores_excessively_nested_json. That test builds a 2000 deep nested array expecting RecursionError from json.loads, but on Python 3.14 it parses fine, reaches the field access and hits the AttributeError instead.

Verification

  • Focused: 154 passed, 1 skipped across tests/test_sleep_engine.py and tests/test_copilot_exec_backend.py.
  • Full suite: 1097 passed, 10 skipped, 2 failed, down from 3 failures on main.
  • ruff check on both changed files reports 17 errors before and after, none on the touched lines. They are pre-existing (import tempfile, shutil, stat, trailing whitespace in tests, an unused logging import) and left alone to keep the diff reviewable.

No documentation changes, so mkdocs build --strict was not run.

Environment

macOS 15, Python 3.14.6, branched from main at 9c776fc

CopilotCliBackend._parse_jsonl_response assumed the data field of an
assistant.message event was an object, so a truthy non-dict value raised
AttributeError from the field access. That escaped the per-line try, which
only wraps json.loads, and killed the parse of the entire stream.

Port the isinstance guard already used by parse_copilot_jsonl in
skillopt/model/copilot_backend.py, which was hardened in 5497a31 but did not
reach this vendored copy. The wider except clause is kept, since json.loads
raises RecursionError rather than JSONDecodeError on deeply nested payloads.

Fixes the pre-existing failure in
tests/test_sleep_engine.py::TestCopilotBackend::test_parse_jsonl_ignores_excessively_nested_json

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

pravit-amp please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copilot backend in skillopt_sleep crashes when an assistant.message event has non-dict data

1 participant