Toggle menus on click - #793
Open
Elijah Koulaxis (kx0101) wants to merge 4 commits into
Open
Conversation
|
Yes please, good fix 👍️ |
Leonard Hecker (lhecker)
changed the title
Leonard Hecker (lhecker)
approved these changes
Aug 6, 2026
Leonard Hecker (lhecker)
left a comment
Leonard Hecker (lhecker)
left a comment
Member
There was a problem hiding this comment.
I made some mild adjustments, but the PR was great overall!
(In particular, one of the branches wasn't needed.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80
menus now close when their button is clicked again
we track which menu button opened through
menubar_toggle_idfield onTui. When a menu button is clicked and its ID matches the stored toggle ID, focus is popped to close the menuThen, the toggle ID is only set after the mouse is released, so that we avoid situations where first click immediately triggers the close
It's cleared when focus leaves the menubar entirely