Fix native component alignment and loading visuals - #4321
Merged
Merged
Conversation
Center unconstrained font line boxes in icon and Avatar frames, center layout-stable labels without stretching Text, and keep Input spacing outside the native editor while preserving its pointer target. Add baseline examples, native geometry regression coverage, and durable authoring guidance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve native alignment and Avatar activity-ring fixes while integrating desktop focus management, dependency updates, and agent permissions. Reconcile Input padding activation with the shared focus target and retain all executable story type coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use non-interaction JavaScript animation loops for macOS Fabric while preserving other renderers' requested drivers. Keep Skeleton silhouettes visible, calculate native Spinner arcs from circumference, and add native pixel-motion and AX-safe alignment coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adapt the existing Shimmer gradient pattern with aspect-ratio-independent geometry, unique gradient IDs, RTL travel, and explicit handling of opaque native colors. Restore the intended Storybook canvas surface so Secondary Button fills remain distinguishable without changing Button tokens. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Bundle size reportTree-shaken production Metro bundles. Component costs are relative to their platform shell; shell costs are absolute.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Jason Morse (JasonVMo)
enabled auto-merge (squash)
September 23, 2026 00:27
Anandraj (mganandraj)
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
The layout primitives use shared React Native code. Native verification for this work focused on desktop; iOS and Android were not natively qualified.
Description of changes
pathLengthnormalization.Related to #4274; this is partial component-readiness work, not completion of that rollup.
Verification
Recorded during implementation on this branch:
#fafafaover#f5f5f5; Dark uses#1f1f1fover#141414. Hover, held press, and release retain the existing component colors.Native SVG cannot interpolate opaque platform-color stops, so Skeleton explicitly remains static with a native outline and a development diagnostic for those colors. Native high-contrast palette rendering on macOS remains unqualified. This PR does not claim fresh VoiceOver, iOS/Android, or final Windows Fabric visual qualification.
Pull request checklist
This PR has considered (when applicable):