Skip to content

Migrate Windows file clients to the broker - #1363

Merged
Weidong Cui (wdcui) merged 4 commits into
uliteboxfrom
wdcui/ulitebox/broker-files-10-windows-clients
Sep 14, 2026
Merged

Weidong Cui (wdcui) merged 4 commits into
uliteboxfrom
wdcui/ulitebox/broker-files-10-windows-clients

Conversation

@wdcui

@wdcui Weidong Cui (wdcui) commented Sep 13, 2026

Copy link
Copy Markdown
Member

This PR migrates Windows file, registry, PE loader, NLS, section, and runner operations to broker-backed LiteBox file APIs, stores registry keys and typed values under the reserved /registry namespace, requires broker-provided filesystem contents, and adds shared in-process broker coverage for the migrated behavior.

@wdcui
Weidong Cui (wdcui) force-pushed the wdcui/ulitebox/broker-files-09-windows-facade branch from 4b68be6 to 87766e8 Compare September 13, 2026 00:54
@wdcui
Weidong Cui (wdcui) force-pushed the wdcui/ulitebox/broker-files-10-windows-clients branch from e7bd400 to aa180f9 Compare September 13, 2026 00:54
@wdcui
Weidong Cui (wdcui) force-pushed the wdcui/ulitebox/broker-files-09-windows-facade branch from 87766e8 to 27ca543 Compare September 14, 2026 21:17
Base automatically changed from wdcui/ulitebox/broker-files-09-windows-facade to ulitebox September 14, 2026 21:50
@wdcui
Weidong Cui (wdcui) force-pushed the wdcui/ulitebox/broker-files-10-windows-clients branch from aa180f9 to 7b99a37 Compare September 14, 2026 22:07
Weidong Cui (wdcui) and others added 4 commits September 14, 2026 16:42
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 239ec5f7-870a-4259-bcae-4ca85fb913a0
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 239ec5f7-870a-4259-bcae-4ca85fb913a0
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 239ec5f7-870a-4259-bcae-4ca85fb913a0
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 239ec5f7-870a-4259-bcae-4ca85fb913a0
@wdcui
Weidong Cui (wdcui) force-pushed the wdcui/ulitebox/broker-files-10-windows-clients branch from 3946beb to 555a9e5 Compare September 14, 2026 23:43
@wdcui
Weidong Cui (wdcui) added this pull request to the merge queue Sep 14, 2026
@github-actions

Copy link
Copy Markdown

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details
--- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field ---

Description:
A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field CliArgs.broker_control_channel in /home/runner/work/litebox/litebox/litebox_runner_windows_on_linux_userland/src/lib.rs:44
  field CliArgs.broker_proxy_url in /home/runner/work/litebox/litebox/litebox_runner_windows_on_linux_userland/src/lib.rs:53

--- failure struct_pub_field_missing: pub struct's pub field removed or renamed ---

Description:
A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_pub_field_missing.ron

Failed in:
  field initial_files of struct CliArgs, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-ulitebox/42a6dbcf3605a4ec8fb3f188530db4e288ce6c97/litebox_runner_windows_on_linux_userland/src/lib.rs:37

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron

Failed in:
  WindowsShimBuilder::new, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-ulitebox/42a6dbcf3605a4ec8fb3f188530db4e288ce6c97/litebox_shim_windows/src/lib.rs:409
  WindowsShimBuilder::default_fs, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-ulitebox/42a6dbcf3605a4ec8fb3f188530db4e288ce6c97/litebox_shim_windows/src/lib.rs:426

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/method_parameter_count_changed.ron

Failed in:
  litebox_shim_windows::WindowsShim::load_program takes 4 parameters in /home/runner/work/litebox/litebox/target/semver-checks/git-ulitebox/42a6dbcf3605a4ec8fb3f188530db4e288ce6c97/litebox_shim_windows/src/lib.rs:510, but now takes 3 parameters in /home/runner/work/litebox/litebox/litebox_shim_windows/src/lib.rs:492

Merged via the queue into ulitebox with commit 091a63d Sep 14, 2026
10 checks passed
@wdcui
Weidong Cui (wdcui) deleted the wdcui/ulitebox/broker-files-10-windows-clients branch September 14, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant