Implemented dynamic holiday and event multipliers in sales generation… - #66
Open
Vijay Rajesh R (vijayrajeshr) wants to merge 4 commits into
Open
Implemented dynamic holiday and event multipliers in sales generation…#66Vijay Rajesh R (vijayrajeshr) wants to merge 4 commits into
Vijay Rajesh R (vijayrajeshr) wants to merge 4 commits into
Conversation
Vijay Rajesh R (vijayrajeshr)
requested review from
Avijit-Microsoft and
Roopan-Microsoft
as code owners
June 18, 2026 08:15
Vijay Rajesh R (vijayrajeshr)
requested a review
from Anish Arora (aniaroramsft)
as a code owner
June 18, 2026 08:15
Copilot started reviewing on behalf of
Vijay Rajesh R (vijayrajeshr)
June 18, 2026 08:16
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the retail data generator’s growth/event logic to produce more realistic seasonality by applying date-driven multipliers for major retail events, and refreshes included sample outputs to reflect the new generation behavior.
Changes:
- Implemented calendar-aware market event detection in
get_market_event_multiplier()(Memorial Day, Black Friday/Cyber Monday, Holiday Rush, Christmas Day). - Updated the generated sales summary to reflect new seasonal patterns/aggregates.
- Regenerated a sample finance account CSV for the camping domain.
Reviewed changes
Copilot reviewed 2 out of 18 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/fabric/datagen/business_growth_logic.py | Adds dynamic, date-based market event multipliers to influence order frequency/size. |
| src/fabric/datagen/output/sample_sales_data_summary.md | Updates the included generation summary metrics to match new event behavior. |
| src/fabric/datagen/output/finance/camping/Account_Samples_Camping.csv | Refreshes the sample camping finance accounts dataset. |
Comment on lines
+66
to
+69
| Includes: | ||
| - Memorial Day Weekend: 1.4x frequency, 1.2x size | ||
| - Black Friday / Cyber Monday: 1.8x frequency, 1.3x size | ||
| - Holiday Rush (Dec 10-24): 1.5x frequency, 1.25x size |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Author
|
@microsoft-github-policy-service agree |
Copilot started reviewing on behalf of
Vijay Rajesh R (vijayrajeshr)
June 18, 2026 08:44
View session
Comment on lines
+2
to
+4
| 53509791-8778-41a9-9bc3-4ff32a9d0159,ACC-Camping-1000,CID-001,Receivable,Active,2025-01-01,,0.0,USD,Customer receivable account (Camping),SampleGen | ||
| 2876a632-b6a5-41d3-9ac8-0daca7db086c,ACC-Camping-1001,CID-002,Receivable,Active,2025-01-01,,0.0,USD,Customer receivable account (Camping),SampleGen | ||
| bdc07886-ef98-4807-9695-f706738ece24,ACC-Camping-1002,CID-003,Receivable,Active,2025-01-01,,0.0,USD,Customer receivable account (Camping),SampleGen |
There was a problem hiding this comment.
Anish Arora (@aniaroramsft)
Roopan-Microsoft
Avijit-Microsoft
Please take a look at this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid:
Other Information
get_market_event_multiplier()always returned a constant baseline: