fix: correct repository directory reference in ontology deployment - #81
Merged
Conversation
Yamini Dhiman (Yamini1-Microsoft)
requested a review
from Avijit-Microsoft
as a code owner
August 7, 2026 07:42
Yamini Dhiman (Yamini1-Microsoft)
had a problem deploying
to
production
August 7, 2026 07:42 — with
GitHub Actions
Failure
Copilot started reviewing on behalf of
Yamini Dhiman (Yamini1-Microsoft)
August 7, 2026 07:43
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Fabric solution installer notebook’s ontology deployment to pass the workspace-scoped repository path (explicitly cast to str) into deploy_ontology, aligning ontology discovery with the artifacts directory used for Fabric deployments.
Changes:
- Update the
deploy_ontology(...)call to userepository_directory=str(workspace_directory)instead ofrepo_root_directory.
Avijit-Microsoft
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes a small but important change to the ontology deployment process in the
fabric_solution_installer.ipynbnotebook. The change ensures that therepository_directoryparameter is explicitly converted to a string when deploying ontologies, which can help prevent potential type errors.infra/fabric/deploy/fabric_solution_installer.ipynb: Changed therepository_directoryargument in thedeploy_ontologycall to usestr(workspace_directory)instead ofrepo_root_directory.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information