chore: dev to main merge - #84
Merged
Merged
Conversation
fix: correct repository directory reference in ontology deployment
chore: main to dev down merge
Saswato-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay Sharma (Vinay-Microsoft) and
Anish Arora (aniaroramsft)
as code owners
August 10, 2026 04:46
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Fabric solution installer notebook to change how the ontology deployment helper is invoked, specifically adjusting the repository_directory argument passed into deploy_ontology().
Changes:
- Update the
deploy_ontology()call to passrepository_directory=str(workspace_directory)instead ofrepo_root_directory.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Avijit-Microsoft
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes a small change to the way the ontology deployment function is called, ensuring that the
repository_directoryparameter is always passed as a string. This improves compatibility and consistency in the deployment process.repository_directoryargument in thedeploy_ontologycall to usestr(workspace_directory)instead ofrepo_root_directory, ensuring the parameter is explicitly a string.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information