Skip to content

chore: dev to main merge - #84

Merged
Avijit-Microsoft merged 3 commits into
mainfrom
dev
Aug 10, 2026
Merged

chore: dev to main merge#84
Avijit-Microsoft merged 3 commits into
mainfrom
dev

Conversation

@Saswato-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request makes a small change to the way the ontology deployment function is called, ensuring that the repository_directory parameter is always passed as a string. This improves compatibility and consistency in the deployment process.

  • Changed the repository_directory argument in the deploy_ontology call to use str(workspace_directory) instead of repo_root_directory, ensuring the parameter is explicitly a string.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Fabric solution installer notebook to change how the ontology deployment helper is invoked, specifically adjusting the repository_directory argument passed into deploy_ontology().

Changes:

  • Update the deploy_ontology() call to pass repository_directory=str(workspace_directory) instead of repo_root_directory.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread infra/fabric/deploy/fabric_solution_installer.ipynb
@Avijit-Microsoft
Avijit-Microsoft merged commit c5a0641 into main Aug 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants