[stable13.1] sim theming editor (#11554) - #11565
Merged
Abhijith Chatra (abchatra) merged 1 commit intoSep 1, 2026
Merged
Conversation
* sim theming editor * more 'fixes' (still reading them but addressing known issues) * more fixes * modal button * unsigned arduino feedback * further requests from jacqueline + ability to set default sim theme * fix lifecycle bug, where it didn't update sim in theme editor fast enough / required an edit to rerender * dropdown for skin choice as well * knob, skin -> layout * first pass cleanup * allow layouts to override which colors are valid * save -> apply * make sure sim theming won't leak into editors that do not have it enabled; only change for microbit should be 'apply' button * fixes for persistence & apply not save for theme as well
Joey Wunderlich (jwunderl)
requested a review
from Abhijith Chatra (abchatra)
September 1, 2026 00:35
Abhijith Chatra (abchatra)
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sim theming editor
more 'fixes' (still reading them but addressing known issues)
more fixes
modal button
unsigned arduino feedback
further requests from jacqueline + ability to set default sim theme
fix lifecycle bug, where it didn't update sim in theme editor fast enough / required an edit to rerender
dropdown for skin choice as well
knob, skin -> layout
first pass cleanup
allow layouts to override which colors are valid
save -> apply
make sure sim theming won't leak into editors that do not have it enabled; only change for microbit should be 'apply' button
fixes for persistence & apply not save for theme as well