Unified GPU shaders#3483
Open
billti wants to merge 7 commits into
Open
Conversation
Member
Author
|
Note, there's a few wgsl-analyzer bugs on the backlog to be fixed before this code will show error free, specifically the below (that I know of right now), so expect some spurious errors in the editor still in the meantime wgsl-analyzer/wgsl-analyzer#703 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the base and adaptive shaders back into one shader (WGSL) file. This removes a bunch of duplication that had to be kept in sync. (The bulk of the lines changed are merging code from the old wgsl files into the new one).
It also enables using tools such as the wgsl-analyzer VS Code extension https://github.com/wgsl-analyzer/wgsl-analyzer to reason about the file wholistically. I added regions the extension recognizes so the common areas can be collapsed for easy navigation...
And when the extension can see all the code it enables type inlay hints, goto def, etc.
This unification also puts in place the structure for some further optimizations I want to experiement with in the near future.