Preserve outer borders when merging table cells - #3462
Merged
Julia Roldi (juliaroldi) merged 3 commits intoSep 21, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Julia Roldi (juliaroldi)
marked this pull request as ready for review
September 10, 2026 19:11
Jiuqing Song (JiuqingSong)
approved these changes
Sep 14, 2026
Jiuqing Song (JiuqingSong)
approved these changes
Sep 21, 2026
Julia Roldi (juliaroldi)
deleted the
u/juliaroldi/border-merged-cells
branch
September 21, 2026 16:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
mergeTableCellsto preserve the right and bottom borders that delimit the selected merge area while retaining the top and left borders from the first cell. Remove internal first-cell borders when the corresponding outer edge has no border, and add coverage for both behaviors.Before:
After:
How to test
yarn test:fast --testPathPattern=mergeTableCells.