Repository navigation
Remove dependencies on 'venv' target since 'uv run' doesn't need a venv - #357
Open
Guido van Rossum (gvanrossum) wants to merge 1 commit into
Open
Guido van Rossum (gvanrossum) wants to merge 1 commit into
Guido van Rossum (gvanrossum) wants to merge 1 commit into
Conversation
Guido van Rossum (gvanrossum)
requested a review
from Bernhard Merkle (bmerkle)
October 18, 2026 23:58
Bernhard Merkle (bmerkle)
approved these changes
Oct 19, 2026
Bernhard Merkle (bmerkle)
left a comment
Bernhard Merkle (bmerkle)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I checked make all from a fresh worktree with no .venv: uv run bootstraps it fine and everything passes. CI picks up UV_PYTHON via uv run too.
Nit: make help still says make all # venv, format, ruff, check, test, build, so venv should be dropped there.
Minor: the install-uv / install-libatomic hints are now only printed by make venv, so someone hitting the libatomic pyright error via make check won't see them. Maybe mention them in make help?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the venv and .venv and sync targets for backwards compatibility.