Repository navigation
Fix truncated container file reads - #632
Merged
Brandon Waterloo [MSFT] (bwateratmsft) merged 1 commit intoOct 7, 2026
Merged
Brandon Waterloo [MSFT] (bwateratmsft) merged 1 commit into
Brandon Waterloo [MSFT] (bwateratmsft) merged 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: aec80380-3c6a-4c1e-9039-11bf00ea54f6
Brandon Waterloo [MSFT] (bwateratmsft)
marked this pull request as ready for review
October 7, 2026 16:48
Brandon Waterloo [MSFT] (bwateratmsft)
requested a review
from a team
as a code owner
October 7, 2026 16:48
Copilot started reviewing on behalf of
Brandon Waterloo [MSFT] (bwateratmsft)
October 7, 2026 16:48
View session
Brandon Waterloo [MSFT] (bwateratmsft)
enabled auto-merge (squash)
October 7, 2026 16:49
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The stream lifecycle and failure-propagation changes are well tested but warrant final maintainer review.
0 open findings
What changed in this PR
Fixes truncated container downloads by correctly awaiting stream completion and tar extraction.
Changes:
- Adds backpressure-aware in-memory tar extraction.
- Propagates incomplete and failed reads.
- Adds comprehensive Linux, Windows, large-file, and failure regression tests.
| File | Description |
|---|---|
src/utils/tarUtils.ts |
Implements awaited in-memory tar parsing. |
src/runtimes/files/ContainerFilesProvider.ts |
Pipelines container output through extraction or raw accumulation. |
src/test/utils/tarUtils.test.ts |
Tests extraction lifecycle and failures. |
src/test/runtimes/files/ContainerFilesProvider.test.ts |
Tests complete reads and filesystem operations. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Patrick Verbrugge (patverb)
approved these changes
Oct 7, 2026
Brandon Waterloo [MSFT] (bwateratmsft)
deleted the
bwateratmsft-container-file-truncation
branch
October 7, 2026 17:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
Fixes #631.
Validation
UPDATE: I did the manual testing, all green.