Fix document editor ETag concurrency handling - #3269
Open
jibin jose (jibin7jose) wants to merge 2 commits into
Open
Fix document editor ETag concurrency handling#3269jibin jose (jibin7jose) wants to merge 2 commits into
jibin jose (jibin7jose) wants to merge 2 commits into
Conversation
Dmitrii Shilov (bk201-)
previously approved these changes
Aug 17, 2026
Author
|
Thanks for the heads-up. I’ll fix the conflicts and check the build failure. |
Member
|
Hi jibin jose (@jibin7jose), thank you for working on this and for the thorough implementation and tests. I merged the core concurrency fix through #3266, since it overlapped with the partition-key move data-loss flow addressed there. The merged implementation stores the loaded ETag as trusted extension-host state, keeps Overwrite conditional against the latest server version, and protects partition-key moves through create-before-delete and recoverable cleanup. The Compare feature remains unique to this PR and would still be valuable. Could you update this branch from main and narrow the PR to adding Compare on top of the merged conflict handling? |
jibin jose (jibin7jose)
force-pushed
the
fix/document-editor-etag-conflict
branch
from
August 17, 2026 09:05
cc30ce2 to
7009811
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3263
Summary
If-Matchprecondition handling to document editor saves using the loaded_etag.412precondition failures and surface a conflict flow instead of silently overwriting._etagguard coverage with unit tests.