Repository navigation
Fix repeated message-loading errors on startup - #5080
Merged
Merged
Conversation
…solve its own localization messages.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are blocking approval.
No open issues 🎉
What changed in this PR
Addresses #5051’s repeated startup message-loading errors by preserving debug-core’s module layout and localization resources, while importing only the components the extension uses. Browser launch and attachment behavior remain unchanged.
Changes:
- Externalizes debug-core and includes production dependencies in the VSIX.
- Replaces package-wide imports with targeted module imports and adds declaration mappings.
- Adds localization and packaging regression tests and updates existing mocks.
| File | Description |
|---|---|
webpack.config.js |
Keeps debug-core imports external so adjacent message resources resolve. |
tsconfig.json |
Maps runtime module paths to published type declarations. |
test/devtoolsPanel.test.ts |
Updates mocks for the targeted transformer import. |
test/chromeDebugCoreNls.test.ts |
Tests message loading, locale fallback, substitution, and packaged resources. |
src/utils.ts |
Imports only the required debug-core utilities. |
src/extension.ts |
Uses targeted attachment helpers and a type-only target import. |
src/devtoolsPanel.ts |
Imports the URL path transformer directly. |
.vscodeignore |
Allows production dependencies and localization resources into the VSIX. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5051, which reports eight message-loading errors whenever the extension starts.
Packages the supporting library with the message files it needs, so it can find them normally.
Loads only the parts of the library the extension uses, avoiding unnecessary debugger startup.
Keeps this change focused on message loading; browser launch and attachment behavior are unchanged.