Skip to content

Fix repeated message-loading errors on startup - #5080

Merged
Vidal Ortega (vidorteg) merged 4 commits into
mainfrom
user/vidorteg/fix-issues
Nov 4, 2026
Merged

Vidal Ortega (vidorteg) merged 4 commits into
mainfrom
user/vidorteg/fix-issues

Conversation

@vidorteg

@vidorteg Vidal Ortega (vidorteg) commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #5051, which reports eight message-loading errors whenever the extension starts.
Packages the supporting library with the message files it needs, so it can find them normally.
Loads only the parts of the library the extension uses, avoiding unnecessary debugger startup.
Keeps this change focused on message loading; browser launch and attachment behavior are unchanged.

@vidorteg Vidal Ortega (vidorteg) changed the title Moving vscode-chrome-debug-core out of main package so that it can re… Fix repeated message-loading errors on startup Oct 29, 2026
@vidorteg
Vidal Ortega (vidorteg) marked this pull request as ready for review October 30, 2026 22:08
Copilot AI balanced review requested due to automatic review settings October 30, 2026 22:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are blocking approval.

No open issues 🎉

What changed in this PR

Addresses #5051’s repeated startup message-loading errors by preserving debug-core’s module layout and localization resources, while importing only the components the extension uses. Browser launch and attachment behavior remain unchanged.

Changes:

  • Externalizes debug-core and includes production dependencies in the VSIX.
  • Replaces package-wide imports with targeted module imports and adds declaration mappings.
  • Adds localization and packaging regression tests and updates existing mocks.
File Description
webpack.config.js Keeps debug-core imports external so adjacent message resources resolve.
tsconfig.json Maps runtime module paths to published type declarations.
test/​devtoolsPanel.test.ts Updates mocks for the targeted transformer import.
test/​chromeDebugCoreNls.test.ts Tests message loading, locale fallback, substitution, and packaged resources.
src/​utils.ts Imports only the required debug-core utilities.
src/​extension.ts Uses targeted attachment helpers and a type-only target import.
src/​devtoolsPanel.ts Imports the URL path transformer directly.
.vscodeignore Allows production dependencies and localization resources into the VSIX.

Review effort: Balanced

@guangyuexu Guangyue Xu (guangyuexu) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .vscodeignore Resolved
@vidorteg
Vidal Ortega (vidorteg) merged commit bd502a1 into main Nov 4, 2026
7 checks passed
@vidorteg
Vidal Ortega (vidorteg) deleted the user/vidorteg/fix-issues branch November 4, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.1.12 logs 'Failed to load message bundle for file …\out\extension' eight times on every activation

3 participants