fix: guard extension.requires against non-iterable values on iOS 26.5 JavaScriptCore - #102
Draft
rajkumargaramie with Copilot wants to merge 2 commits into
Draft
fix: guard extension.requires against non-iterable values on iOS 26.5 JavaScriptCore#102rajkumargaramie with Copilot wants to merge 2 commits into
rajkumargaramie with Copilot wants to merge 2 commits into
Conversation
… on iOS JavaScriptCore
Copilot
AI
changed the title
[WIP] Fix TypeError on Array.from() when requires is a plain object
fix: guard extension.requires against non-iterable values on iOS 26.5 JavaScriptCore
Jun 17, 2026
rajkumargaramie
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS 26.5's JavaScriptCore can produce a plain object
{}forextension.requiresat runtime. CallingArray.from({})inExtensionManager.setupExtensionsthrows an uncatchableTypeError: {} is not iterable, crashing editor initialization.Changes —
packages/editor/src/ExtensionManager.ts:Array.from(extension.requires)with anArray.isArray()guard, falling back to[]for non-array values — consistent with the identical guard already present at line 220 of the same fileRelated Issue
Checklist
I have read CONTRIBUTING.md
I ran
deno task postinstallMy commits follow Conventional Commits
I added tests or documentation if needed
I have performed a self-review of my code
All commits are meaningful (no trivial
fix: typo)I have added tests that prove my fix is effective or that my feature works
Type of change: