LSP experiments - #20
Draft
ggodlewski wants to merge 34 commits into
Draft
Conversation
ggodlewski
marked this pull request as draft
October 11, 2025 13:43
ggodlewski
force-pushed
the
lsp-experiments
branch
from
November 4, 2025 18:02
6dacd1c to
93cb93b
Compare
- Add Content-Length header support for standard LSP protocol - Implement "awesome mode" detection for headerless JSON-RPC - Add message buffering to handle fragmented WebSocket frames - Fix LSP handshake to send initialize on connection - Add isInitialized state tracking separate from connection - Display LSP server messages as toast notifications in editor UI - Support both Blob and ArrayBuffer WebSocket message types - Default to standard mode, auto-detect and switch to awesome mode Transport layer now properly handles both LSP protocol modes: standard (with Content-Length headers) and "awesome" (raw JSON). Client starts in standard mode to ensure handshake succeeds, then adapts to server preference based on first response format. UI enhancements include color-coded toast notifications for LSP window/logMessage events with auto-fade after 3 seconds.
…ection stability and user awareness
…s for better visibility
…sions When joining a YJS collaborative room from a new browser, ensure didOpen is sent with the actual synchronized document content instead of empty text. Changes: - Wait for content to arrive before opening LSP file - Check content length on 'changed' events - Add 1-second timeout fallback for edge cases - Prevent duplicate initialize requests when already connected This ensures LSP features (diagnostics, completions) work correctly when joining existing collaborative sessions.
Member
|
@ggodlewski work with Drew to get back on my calendar. I fixed it. Also you can run against https://lsp-toy.opensource.mieweb.org in the demo. It is running and will detect websocket and work. |
ggodlewski
force-pushed
the
main
branch
3 times, most recently
from
December 11, 2025 19:27
d622e5c to
31a9a56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.