ui: extend Liquid Glass to the remaining over-video chrome - #172
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR finishes the “over-video chrome uses GlassPill” checklist by converting the remaining video-overlaid scrims to GlassPill (native Liquid Glass on iOS 26+, dark scrim fallback elsewhere), aligning the export/subtitles overlays and recorder top bar with the existing recorder glass chrome.
Changes:
- Subtitles editor: converts the center ▶ overlay badge to
GlassPill(including compact/text mode sizing). - Recorder: wraps the timer readout in a small
GlassPillnext to the glass close button and removes the now-redundant text shadow. - Export: converts the ▶ badge, meta pill, and caption badge (spinner + pressable variants) to
GlassPill, and adjusts sizing to match the recorder preview card.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/subtitles.tsx | Replaces the over-video ▶ scrim badge with GlassPill, keeping existing sizing variants. |
| src/app/recorder.tsx | Adds a glass timer pill to unify the top bar chrome and removes timer text shadow. |
| src/app/export.tsx | Moves all over-video export overlays (▶, meta pill, captions badge) onto GlassPill and updates sizing/structure for shared surfaces. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SarkarShubhdeep
approved these changes
Aug 25, 2026
SarkarShubhdeep
left a comment
SarkarShubhdeep
left a comment
Collaborator
There was a problem hiding this comment.
All simple UI updates. Looks fine.
morepriyam
force-pushed
the
feat/glass-remaining
branch
from
August 26, 2026 05:35
8566e29 to
609a746
Compare
Converts the last flat-scrim overlays to GlassPill (Liquid Glass on iOS 26+, the usual dark scrim elsewhere), completing the glass system: glass = chrome floating over video, themed screens stay flat. - export: ▶ play badge goes glass and grows 56→64pt / 28pt glyph to match the recorder preview card; clip-count · duration meta pill goes glass; caption badge goes glass and grows 30→40pt with a 20pt icon (48pt effective target with hitSlop — it had the same sub-HIG tap target problem as the preview card badges), split into placement + surface so the spinner and pressable variants share the surface - subtitles: ▶ play badge goes glass, keeping the 48pt / 32pt-compact text-mode sizing - recorder: the top timer sits in a small glass pill next to the glass close button; the text shadow is dropped — the pill's dimming layer does that job now The export/subtitles close buttons deliberately stay flat: dark-pinned glass over a light themed background turns nearly transparent, and the glass rule reserves glass for chrome over video anyway. Closes #168
morepriyam
force-pushed
the
feat/glass-remaining
branch
from
August 26, 2026 05:36
609a746 to
4fdfeeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #168.
Stacked on #171; only the last commit is this PR's change. With the preview-card set (#169) and the segment-bar container (#170) already converted, this finishes the checklist — every flat scrim floating over video now goes through
GlassPill(Liquid Glass on iOS 26+, the usual dark scrim on Android/older iOS).Changes
Export screen (over the merged video only — the themed body stays flat)
Subtitles editor
Recorder
Deliberately not converted (per the audit on the issue)
Testing
tsc --noEmit, ESLint, and the jest suite clean