Repository navigation
Conversation
callActionForModule() streams the core-format file descriptor and leaves the content empty. Cores without mikopbx/Core#1167 (all releases up to 2026.4.47) then pass json_decode('') = null to ModulesControllerBase::handleResponse(array): a TypeError after the body on every getcfg/getimg (Sentry MIKOPBX-N6K). The unconditional sendRaw() after it throws "Response was already sent" when handleFileStreaming() has already answered 404 because a parallel request for the same MAC removed the file (Sentry MIKOPBX-PWC). getConfig() and getImg() now send the request to the backend worker themselves, with the payload callActionForModule() builds, and call sendRaw() only if nothing was sent yet. File answers are unchanged. With no file (unknown MAC, rejected image name) the status is 422, on a worker timeout or error 400 (was 200); the JSON body is the same.
…e-format-f fix(rest): stream getcfg/getimg without callActionForModule() (#22)
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.67: merge
developintomaster. Merge with a merge commit, as for 1.65 and 1.66; the push tomasterrunsbuild.ymland publishes the release.What is in it
callActionForModule()(getcfg/getimg: stop routing core-format file answers through callActionForModule() (TypeError after the body, Sentry MIKOPBX-N6K) #22, PR fix(rest): stream getcfg/getimg without callActionForModule() (#22) #26). The phone gets the same bytes and headers. Removed:Verified before #26 was merged: live A/B on Core develop 0e5316f1 and on Core PR #1169 (body md5 and headers unchanged, 0 TypeError, 0 «already sent» on 12 parallel getcfg). See #26.
Релиз 1.67: getcfg/getimg без
callActionForModule()(#22). Телефон получает те же байты и заголовки.