Repository navigation
Fix link freshness crashes and make scan results visible - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
The weekly link scan crashed on a Chinese URL in run 40295619737.
continue-on-errorstill marked the job successful and no report was produced.Encode Unicode request paths and queries for HEAD and GET, correct the affected Google Books source to its stable volume-ID URL, and publish a readable job summary with scan coverage and URLs needing review. Keep ordinary network findings advisory while allowing unexpected checker errors to fail the job. Run this diagnostic on PRs that change its workflow, script or tests.
Why is it correct?
UnicodeEncodeErrorin urllib's ASCII request encoding.Checks
Safety
No credentials or restricted data added; generated files are synchronized; catalog statuses are unchanged.