Skip to content

Fix link freshness crashes and make scan results visible - #13

Merged
mimaowang merged 1 commit into
mainfrom
codex/fix-link-freshness-20261026
Oct 26, 2026
Merged

mimaowang merged 1 commit into
mainfrom
codex/fix-link-freshness-20261026

Conversation

@mimaowang

@mimaowang mimaowang commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

What changed?

The weekly link scan crashed on a Chinese URL in run 40295619737. continue-on-error still marked the job successful and no report was produced.

Encode Unicode request paths and queries for HEAD and GET, correct the affected Google Books source to its stable volume-ID URL, and publish a readable job summary with scan coverage and URLs needing review. Keep ordinary network findings advisory while allowing unexpected checker errors to fail the job. Run this diagnostic on PRs that change its workflow, script or tests.

Why is it correct?

  • The original log ends with UnicodeEncodeError in urllib's ASCII request encoding.
  • The replacement book URL returned HTTP 200 and the same title, 中国农村经济统计大全, 1949-1986. The data record's identity, evidence scope and status are preserved.
  • Network errors retain their reason; a GET fallback reports its own HTTP status. Runtime bugs are no longer swallowed.
  • Derived catalogs and the health report were regenerated. No files or records were deleted.

Checks

  • Full offline release gate passed on the tracked public-version snapshot: credential scan, validator, generators, generated-view check, 71 pytest tests, and Ruff 0.15.21.
  • Validator: 0 errors and one existing duplicate-task-title warning.
  • Seven link-check tests cover Unicode HEAD/GET, fallback status, report completion, strict/advisory exits and propagation of unexpected errors.
  • Local network scan completed, but local DNS resolves public targets to non-public addresses; existing guards blocked them. These results are not evidence of dead links. The GitHub-hosted scan 40309000568 completed all 150 URLs without a traceback and reported 56 non-successful requests for review. Both push and pull-request quality gates passed; the new link workflow passed and no longer emits the process-exit error annotation.

Safety

No credentials or restricted data added; generated files are synchronized; catalog statuses are unchanged.

@mimaowang
mimaowang merged commit 95dc492 into main Oct 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant