Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…te flagged Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…from the path Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rsion only Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t apart as data Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and drop the dead overlay copy Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…asic and without_missing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ZoranPandovski
left a comment
There was a problem hiding this comment.
Requesting changes mainly for the description. It still describes fetching field values into the pod as DS_C... variables, but 0782d74 replaced that with call_minds_api through the gateway, and the test run it cites (ecbc434) predates that change. Please rewrite it for the gateway design and rerun the full suite on the current head; the linked issue needs the same update.
The optional key, public check and required check changes in connector_auth_rules.py and connector_draft.py are a separate feature shared with cowork-server and inference, and would be easier to review as their own PR.
| """Parse the optional ``custom_api`` block exactly, or refuse the request.""" | ||
| if value is None: | ||
| return None | ||
| if not isinstance(value, dict) or set(value) != {"turn_key", "connections"}: |
There was a problem hiding this comment.
The block has no protocol_version and refuses any extra key, so if cowork-server ever adds a field, every turn with custom connections fails on pods running this version. Adding a version now, or dropping the block with a log line instead of failing the turn, would avoid that.
| credential_version: int | ||
|
|
||
|
|
||
| @dataclass(frozen=True, repr=False) |
There was a problem hiding this comment.
TurnRequestV1 is a plain dataclass whose repr still shows the turn key through llm and oauth, so this does not keep the key out of a printed request. Also, turn_key here must equal llm.api_key and the helper never reads it, so it could be dropped.
| assert ' - 3: "Ops desk" (beta_api)\n' in block | ||
| assert ' - 5: "Prod" (acme_crm)\n' in block | ||
| assert "`call_minds_api(connection_id, path, query=None, headers=None)`" in block | ||
| assert "The user typed only the API's host." in block |
There was a problem hiding this comment.
These assert exact prompt phrases, so any wording change breaks them. The structural asserts above (connection lines, escaping) are enough.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…asic and without_missing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-connector-keys [ENG-3850] Let a connector template mark its key optional and name a public check path
https://linear.app/mindsdb/issue/ENG-3850
What changed
call_minds_api(connection_id, path, query=None, headers=None): one GET through the mindshub_inference gateway, sent with the turn key; the gateway places the member's key, which never enters the podinvalid_custom_api_responseNotes for the reviewer
DS_C…variables; 0782d74 removed that, and the helper replaced it.Ships with
Checks
uv run pytestat 1055772🤖 Generated with Claude Code