Skip to content

fix(argocd-pr-env-deploy): leave customer-labeled PRs to an admin (ENG-3919) - #76

Merged
lucas-koontz merged 1 commit into
mainfrom
fix/eng-3919-customer-env-admin-run
Nov 2, 2026
Merged

lucas-koontz merged 1 commit into
mainfrom
fix/eng-3919-customer-env-admin-run

Conversation

@lucas-koontz

Copy link
Copy Markdown
Contributor

User story

As an operator running a customer environment
I want a PR labeled customer:<hostBase> to deploy nothing through this action
So that only an admin changes a customer environment

Why this matters

The Argo CD token this action holds can read a customer environment's parent but no longer change it. Without this check, every CI run on a customer anchor PR retries argocd app set for 5 minutes, then fails.

What should happen

Right after the action reads the PR's labels, a customer: label ends the job with a notice. No argocd call runs.

Test plan

  • A customer-labeled PR stops before Argo CD: test_a_customer_labeled_pr_stops_before_argocd. It fails against main.
  • An ordinary PR goes on: test_an_ordinary_pr_goes_on.
  • The check runs before any argocd call: test_the_customer_check_runs_before_any_argocd_call.
  • Rollback: revert this PR.

@lucas-koontz
lucas-koontz requested a review from a team as a code owner November 2, 2026 09:45
@lucas-koontz
lucas-koontz merged commit a52a082 into main Nov 2, 2026
6 checks passed
@lucas-koontz
lucas-koontz deleted the fix/eng-3919-customer-env-admin-run branch November 2, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants