Repository navigation
fix(logging): deliver quiet diagnostics through source builds (ENG-3579) - #12504
Merged
Merged
Conversation
This was referenced Oct 21, 2026
Merged
Merged
lucas-koontz
marked this pull request as ready for review
October 21, 2026 07:35
mindsdb-devops
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User story
As an operator building from source
I want quiet diagnostics in the assembled stack
So that I can identify failures without exposing request values
Why this matters
Operators do not receive upstream logging changes until the source gitlinks and images include them. The API and web images now build the coordinated candidate sources with WARNING/errors defaults. The build also passes source-derived package versions and uses the pinned server's canonical health and API routes.
Visual review
A deployed before/after capture remains a rollout gate. The real built-image smoke below verifies the candidate; it does not establish a production log-volume reduction.
Acceptance criteria
How to test
COMPOSE_PROJECT_NAME=logging-review make docker-build; both images must build from source.python3 scripts/test-compose-logging.py --api-image logging-review-api --web-image logging-review-web. It uses disposable loopback-only containers without host data mounts.backend/data-vault/withdocker buildx build --load -t logging-review-data-vault -f docker/mindsdb.Dockerfile .. Check its baked health command, quiet successful/api/statusand/api/util/ping, visible failed requests, request-ID echo and absence of private query values. This two-service Compose topology does not run it.Notes for the reviewer
/api/v1/health/is the canonical endpoint; the previous/healthprobe failed, and/api/v1/fell through to the UI.Verified candidate sources
b73859e9fab97bfd430bf5829d012b9f96b473dbbececf886b489a218e69b7f40d76d7381451b4624bb38de0e4f16535ba3e2eac957d11ef406f7e76075c4e888b1daa15a9725662419cef17fa8e6d6aVerified locally
These checks were repeated after updating all four gitlinks to the reviewed fixes. Images were built locally for arm64 and containers used loopback ports with no host data mounts; every smoke container was removed afterward.
COMPOSE_PROJECT_NAME=eng3579-review-final-20261021 make docker-build: both passed.scripts/test-compose-logging.pypassed the baked health command, API JSON through nginx, quiet probes, visible 401, web access statuses[200, 200, 503], private-value exclusion and graceful stop.2.26.10.21.2rc3.dev2+gb73859e9f, server0.26.10.21.2rc2.dev2+gbececf886, structlog26.1.0.docker/mindsdb.Dockerfilebuild passed. Installed MindsDB26.2.0, SQLAlchemy2.0.55./api/statusand/api/util/pingreturned 200 with no access records even underACCESS_LOG_MODE=all; a missing API route retained a WARNING/404. Request IDs round-tripped and private query values were absent from logs./api/statushealth check; the final candidate no longer does.git diff --check: passed.The updated delivery commit
65ccb0a162d157a57c4e2a02701e208b1e463693has a green hosted Snyk code check. The real builds and smoke evidence above are local. They do not establish provider-backed agent turns, installed-stack promotion, collector/export compatibility or a production log-volume reduction. Existing release pins outside this source build remain separate delivery gates.Ships with
mindsdb/anton#621, mindsdb/cowork-server#741, mindsdb/cowork#1263, mindsdb/data-vault#5.
Merge/release order: mindsdb/anton#621, then mindsdb/cowork-server#741, then mindsdb/cowork#1263. mindsdb/data-vault#5 can proceed independently. Update reviewed release pins and rebuild #12504 last.
The source candidate pins include intervening upstream changes; reviewed release commits are required before promotion.