Skip to content

test(rule_based): add comprehensive unit test coverage for get_identifier_description - #92

Open
mi-vault wants to merge 1 commit into
mindsdb:stagingfrom
mi-vault:test/get-identifier-description-coverage
Open

mi-vault wants to merge 1 commit into
mindsdb:stagingfrom
mi-vault:test/get-identifier-description-coverage

Conversation

@mi-vault

@mi-vault mi-vault commented Nov 15, 2026 •

Copy link
Copy Markdown

Summary

Closes #31

This PR adds the first dedicated unit tests for get_identifier_description and its multiprocessing wrapper get_identifier_description_mp, addressing the gap noted in issue #31.

What's tested

Test class Cases
TestGetIdentifierDescriptionNoInformation Lists, dicts, integers, floats, strings with 1 unique value → 'No Information'
TestGetIdentifierDescriptionForeignKey Integer cols with _id, -id, id, _ID, _Id, bare ID/Id → 'Foreign key'; non-integer dtype does not trigger
TestGetIdentifierDescriptionUUID 50-row UUID columns → 'UUID'
TestGetIdentifierDescriptionUnknownIdentifier High-cardinality short strings with account/user prefix → 'Unknown identifier'
TestGetIdentifierDescriptionHashLike MD5 and SHA-256 hex columns → 'Hash-like identifier'
TestGetIdentifierDescriptionNoneReturn Normal text and float columns → None
TestGetIdentifierDescriptionMpWrapper get_identifier_description_mp matches direct call for all major return values
TestIsForeignKeyName Full edge-case sweep of _is_foreign_key_name incl. non-matches (valid, grid, idea)
TestIsIdentifierName Full sweep of _is_identifier_name

…fier_description

Signed-off-by: mi-vault <asmisharma2026@gmail.com>
@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions Bot added a commit that referenced this pull request Nov 15, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve get_identifier_description testing coverage

1 participant