Repository navigation
Conversation
…fier_description Signed-off-by: mi-vault <asmisharma2026@gmail.com>
|
All contributors have signed the CLA ✍️ ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #31
This PR adds the first dedicated unit tests for
get_identifier_descriptionand its multiprocessing wrapperget_identifier_description_mp, addressing the gap noted in issue #31.What's tested
TestGetIdentifierDescriptionNoInformation'No Information'TestGetIdentifierDescriptionForeignKey_id,-id,id,_ID,_Id, bareID/Id→'Foreign key'; non-integer dtype does not triggerTestGetIdentifierDescriptionUUID'UUID'TestGetIdentifierDescriptionUnknownIdentifier'Unknown identifier'TestGetIdentifierDescriptionHashLike'Hash-like identifier'TestGetIdentifierDescriptionNoneReturnNoneTestGetIdentifierDescriptionMpWrapperget_identifier_description_mpmatches direct call for all major return valuesTestIsForeignKeyName_is_foreign_key_nameincl. non-matches (valid,grid,idea)TestIsIdentifierName_is_identifier_name