Adapt to coqutil Word.Naive on stdlib bits; drop Rocq 9.0 from CI - #561
Merged
Merged
Conversation
This was referenced Sep 12, 2026
Merged
JasonGross
force-pushed
the
fable/zmod-naive
branch
from
September 12, 2026 04:15
144b74a to
de726fc
Compare
Contributor
Author
|
Stacked follow-up: #562 (Kami words on stdlib bits via mit-plv/kami#51; its last four commits are the Kami part). Written by Claude Fable 5.1 via Claude Code (session https://claude.ai/code/session_01YJbiRBkJtM7x6PvYV6hmEm). |
This was referenced Sep 12, 2026
| rewrite Z_mod_same_full. | ||
| reflexivity. | ||
| + cbn in *. exfalso. congruence. | ||
| (* destr already substituted z := word.of_Z 0; word.divu y 0 is Zmod.udiv y zero = opp one *) |
Contributor
There was a problem hiding this comment.
comments that narrate immediately adjacent code are not useful, please remove
Contributor
Author
There was a problem hiding this comment.
Removed, and swept the whole diff of this PR and of the two stacked ones (#562, #563) for comments that narrate adjacent code or describe the change; the substance is in the commit messages now.
Written by Claude Fable 5.1 via Claude Code (session https://claude.ai/code/session_01YJbiRBkJtM7x6PvYV6hmEm).
JasonGross
force-pushed
the
fable/zmod-naive
branch
2 times, most recently
from
September 14, 2026 18:28
9d693f1 to
5202bcf
Compare
andres-erbsen
approved these changes
Sep 14, 2026
…m CI NaiveRiscvWordProperties.v proves riscv_ok by unfolding the Naive instance: word.ok says nothing about shift amounts of width or more or about division by zero, and these five facts are exactly about those cases. The shift cases reduce to the shift amounts agreeing, the division cases to Zmod.udiv_0_r and Zmod.umod_0_r. The rocq/rocq-prover docker images for 9.0 and 9.1 ship rocq-stdlib 9.0, which has no Zmod, so CI tests 9.2 and dev. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJbiRBkJtM7x6PvYV6hmEm
JasonGross
force-pushed
the
fable/zmod-naive
branch
from
September 14, 2026 21:31
5202bcf to
257a21d
Compare
JasonGross
marked this pull request as ready for review
September 14, 2026 22:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapts to coqutil
Word.Naivebeing represented as stdlibbits(mit-plv/coqutil#186): pinsdeps/coqutilto that branch, rewrites the two division-by-zero cases and three shift cases incompiler/src/compiler/NaiveRiscvWordProperties.v(the only file that unfolded the old record), and adjusts CI. Rocq 9.0 and 9.1 are dropped from CI: theirrocq/rocq-proverdocker images ship rocq-stdlib 9.0.0 (noZmod), so CI tests 9.2 and dev; the opam bound staysrocq-stdlib >= 9.1, which does allow Rocq 9.1. Everything inmake all(compiler, processor, end2end, LiveVerif) builds; no other source changes were needed.Depends on mit-plv/coqutil#186; CI cannot fetch the pinned coqutil commit until that merges, so this stays a draft until then.
Written by Claude Fable 5.1.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YJbiRBkJtM7x6PvYV6hmEm