Bump to Rocq 9.0 minimum version - #212
Closed
miriampolzer wants to merge 1 commit into
Closed
Conversation
miriampolzer
force-pushed
the
rocq-9.0-compat
branch
from
August 26, 2026 11:45
075ad7b to
7ca8a57
Compare
miriampolzer
force-pushed
the
rocq-9.0-compat
branch
from
August 26, 2026 12:28
7ca8a57 to
aee288f
Compare
Drop support for Coq <= 8.20 and transition the build system and tooling to Rocq 9.0 minimum. - Update Makefile and Makefile.local.common to use rocq, rocq makefile, and rocq top directly. - Decouple version probing from $(COQC) using ROCQ variable so that wrapper commands and compiler overrides do not break $(COQC) top. - Update Makefile.coq-versions-lite to use rocq --version and rocq compile -config, avoiding conflicting .coq-version strings and preventing infinite makefile remake-and-restart loops. - Update CI scripts (describe-system-config.sh, github-actions-make.sh, coq-opam-package.yml) to invoke rocq directly without legacy coq fallbacks. - Add Rocq 9.0, 9.1, and 9.2 to Docker and Opam CI matrices. - Remove legacy `opam install coq` workaround from Docker CI so that preinstalled Rocq 9.x binaries are preserved in the environment. - Update Debian CI package dependencies to coq, libcoq-stdlib, and libcoq-core-ocaml-dev. - Update coq-rewriter.opam bounds to ocaml >= 4.14.0 and coq >= 9.0~.
miriampolzer
force-pushed
the
rocq-9.0-compat
branch
from
August 28, 2026 11:57
aee288f to
e57bd3d
Compare
JasonGross
requested changes
Aug 28, 2026
| "conf-findutils" {build} | ||
| "ocaml" {build & (arch = "x86_32" | arch = "x86_64" | >= "4.14.0")} | ||
| "coq" {>= "8.19~"} | ||
| "ocaml" {build & >= "4.14.0"} |
Collaborator
There was a problem hiding this comment.
This change isn't quite right, the version bound is specifically to fix #97 . If Rocq 9 requires 4.14 already then we should just do
Suggested change
| "ocaml" {build & >= "4.14.0"} | |
| "ocaml" |
but if Rocq 9 supports older OCaml than we should do
Suggested change
| "ocaml" {build & >= "4.14.0"} | |
| "ocaml" {arch = "x86_32" | arch = "x86_64" | >= "4.14.0"} |
(I was incorrect to ever use build, as OCaml plugins must be recompiled when the version of OCaml changes)
| "ocaml" {build & (arch = "x86_32" | arch = "x86_64" | >= "4.14.0")} | ||
| "coq" {>= "8.19~"} | ||
| "ocaml" {build & >= "4.14.0"} | ||
| "coq" {>= "9.0~"} |
Collaborator
There was a problem hiding this comment.
Shouldn't this be split so as to not require the coq meta package?
Merged
Contributor
|
Merged in #214, so this one can now be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop support for Coq <= 8.20 and transition the build system and tooling to Rocq 9.0 minimum.
MakefileandMakefile.local.commonto userocq,rocq makefile, androcq topdirectly.$(COQC)usingROCQvariable so that wrapper commands and compiler overrides do not break$(COQC) top.Makefile.coq-versions-liteto userocq --versionandrocq compile -config, avoiding conflicting.coq-versionstrings and preventing infinite makefile remake-and-restart loops.describe-system-config.sh,github-actions-make.sh,coq-opam-package.yml) to invokerocqdirectly without legacy coq fallbacks.opam install coqworkaround from Docker CI so that preinstalled Rocq 9.x binaries are preserved in the environment.coq,libcoq-stdlib, andlibcoq-core-ocaml-dev.coq-rewriter.opambounds toocaml >= 4.14.0andcoq >= 9.0~.