Repository navigation
[Improvement] Upgrade MLRun to 1.12.0 and Nuclio to 1.16.10 - #316
Open
royischoss wants to merge 2 commits into
Open
royischoss wants to merge 2 commits into
royischoss wants to merge 2 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
🟡 Changes recommended
The version matrix advertises a nonexistent 0.12.0 GA chart while the package remains 0.12.0-rc.12.
0 open findings
What changed in this PR
Upgrades MLRun CE dependencies to MLRun 1.12.0 and Nuclio 1.17.9.
Changes:
- Updates MLRun and Nuclio chart dependencies and lockfile.
- Aligns component image tags with GA releases.
- Bumps chart metadata and updates the version matrix.
| File | Description |
|---|---|
charts/mlrun-ce/values.yaml |
Uses MLRun chart defaults and pins Jupyter 1.12.0. |
charts/mlrun-ce/requirements.yaml |
Upgrades MLRun and Nuclio dependencies. |
charts/mlrun-ce/requirements.lock |
Locks the upgraded dependencies. |
charts/mlrun-ce/README.md |
Adds the 0.12 version matrix entry. |
charts/mlrun-ce/Chart.yaml |
Bumps chart and application versions. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR upgrades MLRun CE to the MLRun
1.12.0GA release and Nuclio1.16.10.It bumps the MLRun sub-chart from
0.11.23to0.11.29and the Nuclio sub-chart from0.21.27to0.22.10.The MLRun API, log-collector and UI image tags are no longer pinned to
1.12.0-rc25invalues.yaml, so they follow the sub-chart'sappVersion(1.12.0).🛠️ Changes Made
charts/mlrun-ce/requirements.yaml:nuclio:0.21.27→0.22.10(app1.16.10)mlrun:0.11.23→0.11.29(app1.12.0)charts/mlrun-ce/requirements.lock: regenerated viamake helm-update-dependenciescharts/mlrun-ce/values.yaml:image.tag: 1.12.0-rc25overrides frommlrun.api,mlrun.api.sidecars.logCollectorandmlrun.uijupyterNotebook.image.tag:1.12.0-rc25→1.12.0(Jupyter is templated by this chart, so its tag stays pinned)charts/mlrun-ce/Chart.yaml:version0.12.0-rc.11→0.12.0-rc.12,appVersion1.12.0-rc25→1.12.0charts/mlrun-ce/README.md: added a0.12.0row to the version matrix (MLRun1.12.0, Nuclio1.16.10)✅ Checklist
charts/mlrun-ce/Chart.yaml.🧪 Testing
helm lint charts/mlrun-cepasses.helm templaterenders withvalues.yamlalone and combined with each of the three install-mode values files.mlrun-api,mlrun-ui,log-collector,jupyterat1.12.0; Nucliocontrolleranddashboardat1.16.10.helm install(namespace and PVCs wiped first) on the vmdev137ig4 lab cluster was done with the earlier revision of this PR that used Nuclio1.17.9(release deployed, all 26 podsRunning, Kafka clusterReady). It needs to be re-run with Nuclio1.16.10.🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes
1.16.x(chart0.22.10, app1.16.10) rather than the latest1.17.xbecause MLRun1.12.0supports Nuclio1.16.x. Upgrading an existing installation in place has not been tested yet.