fix: emit trailing newline when writing lucide-icon-clusters.json - #195
Merged
Conversation
save_clusters_json wrote the file without a final newline, so every generated Lucide update PR was born red on the end-of-file-fixer pre-commit hook (tests always passed; only lint failed). Append the newline at the source so update PRs land lint-green. Fixes mikemac-bbyd. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013oKQt3S2tWA5TWmq1vLSMN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
save_clusters_jsonwrotesrc/lucide/data/lucide-icon-clusters.jsonwithout a trailing newline, so every generated Lucide update PR was born red on thefix end of filespre-commit hook. Tests always passed; only lint failed. During the 2026-08-23 /prs review, #190, #191, and #194 each had to be fixed by hand (append newline → re-run CI → merge).Fix
Append
"\n"when writing the JSON, so update PRs land lint-green.Fixes
mikemac-bbyd.🤖 Generated with Claude Code