Skip to content

feat: step volume/brightness gestures while dragging - #168

Open
asdolo wants to merge 1 commit into
mmaher88:masterfrom
asdolo:continuous-gesture-volume
Open

feat: step volume/brightness gestures while dragging#168
asdolo wants to merge 1 commit into
mmaher88:masterfrom
asdolo:continuous-gesture-volume

Conversation

@asdolo

@asdolo asdolo commented Oct 25, 2026

Copy link
Copy Markdown

Summary

  • Fire continuous Volume/Brightness gesture actions while dragging (Options+-style), thresholded like thumb-wheel volume
  • Keep one-shot gesture bindings on release; skip release fire if continuous steps already ran
  • Add unit coverage for continuous volume/brightness, reverse drag, and one-shot behavior

Fixes #155.

Test plan

  • ButtonActionDispatcherFixture continuous + one-shot tests
  • Full pre-push suite (C++, tray, QML, pytest)
  • Manual: map gesture Up/Down to VolumeUp/Down, hold + drag — volume ticks while moving, not only on release
  • Manual: one-shot binding (e.g. desktop switch) still fires once on release

@asdolo
feat: step volume/brightness gestures while dragging
ecd9b99 
Match Logi Options+ by firing continuous Volume/Brightness actions
during gesture motion (thresholded), keeping one-shot bindings on
release. Fixes mmaher88#155.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Volume controls with gestures is weird

1 participant

@asdolo