Repository navigation
minor cleanup to bash scripts - #172
Open
slycordinator wants to merge 1 commit into
Open
slycordinator wants to merge 1 commit into
slycordinator wants to merge 1 commit into
Conversation
* Changed to use "#!/usr/bin/env bash" over "#!/bin/bash" as using the one at /bin/bash can be old/outdated with user installing a newer one on their path * in package-arch.sh and package-rpm.sh condensed [ -n "$GITHUB_REF_NAME" ] && [[ "$GITHUB_REF_NAME" =~ ^v[0-9] ]] checks to [[ -n "$GITHUB_REF_NAME" && "$GITHUB_REF_NAME" =~ ^v[0-9] ]] The latter is going to perform slightly quicker by having everything in one call to [[ ]] * in release.sh change numeric bumping to use (( VAR++ )). This is is faster than using $((VAR + 1)). * in package-arch.sh and package-rpm.sh added quotes around nproc calls -not really needed, but shellcheck complains about it without the quotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed to use "#!/usr/bin/env bash" over "#!/bin/bash" as using the one at /bin/bash can be old/outdated with user installing a newer one on their path
in package-arch.sh and package-rpm.sh condensed [ -n "$GITHUB_REF_NAME" ] && [[ "$GITHUB_REF_NAME" =~ ^v[0-9] ]] checks to [[ -n "$GITHUB_REF_NAME" && "$GITHUB_REF_NAME" =~ ^v[0-9] ]]